Skip to content

fix(crasht): metadata correctness#3965

Merged
morrisonlevi merged 1 commit into
masterfrom
levi/crash-metadata
Jun 9, 2026
Merged

fix(crasht): metadata correctness#3965
morrisonlevi merged 1 commit into
masterfrom
levi/crash-metadata

Conversation

@morrisonlevi

@morrisonlevi morrisonlevi commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Description

This fixes some small issues with the metadata:

  1. If the JIT buffer is 0, then opcache was wrongfully marked as disabled. If it's 0, then JIT is disabled, not opcache.
  2. System INI doesn't mean what I thought it did at the time I wrote it, which is that values at startup are consistent. Unfortunately PHP can treat Apache INIs as system settings, for example. So we don't skip over most settings now. Just know that they might be overwritten.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 12 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN Opcache tests: [8.5]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.3]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.4]   View in Datadog   GitLab

View all 12 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 3 jobs - 3 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9977933 | Docs | Datadog PR Page | Give us feedback!

@morrisonlevi morrisonlevi marked this pull request as ready for review June 9, 2026 14:12
@morrisonlevi morrisonlevi requested a review from a team as a code owner June 9, 2026 14:12
@morrisonlevi

Copy link
Copy Markdown
Collaborator Author

ASAN Opcache tests: [8.5] failure is on master, not related. I am looking into that.

@realFlowControl realFlowControl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@morrisonlevi morrisonlevi merged commit 08d5785 into master Jun 9, 2026
2134 of 2148 checks passed
@morrisonlevi morrisonlevi deleted the levi/crash-metadata branch June 9, 2026 16:35
@github-actions github-actions Bot added this to the 1.22.0 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants