Split rinit ordering in "before sidecar init" and "after sidecar init"

[bwoebi]

Fix up after splitting, otherwise e.g. debugger structures aren't initialized yet when sidecar is initialized.

This broke in multi-request scenarios.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48899dc444

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep trace initialization after remote config processing

When remote config changes datadog.trace.enabled during datadog_sidecar_rinit() (it processes RC in ext/sidecar.c:759), this earlier call has already created DDTRACE_G(active_stack). That makes datadog_alter_dd_trace_disabled_config() treat the request as initialized: disabling tracing calls dd_clean_globals() before dd_initialize_request() has initialized those globals, and enabling tracing can call dd_initialize_request() here and then again in the later ddtrace_rinit(). In multi-request sidecar/RC setups this can corrupt request state or crash at RINIT.

Useful? React with 👍 / 👎.

[datadog-prod-us1-4]

 

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 66 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.4]     

See error

Fatal error: Uncaught Exception: wait for replay timeout at /go/src/github.com/DataDog/apm-reliability/dd-trace-php/tmp/build_extension/tests/ext/includes/request_replayer.inc:100

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.5]     

See error

Client-side SHM span stats could not be flushed due to timeout.

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.3, amd64]     

See error

1 failed test. Error: The sidecar trace flusher sender informs about changes to the agent sample rate in agent_sampling_sidecar.phpt.

View all 66 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 24 jobs - 24 passed on retry

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 54.12% (+0.00%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 48899dc | Docs | Datadog PR Page | Give us feedback!}