fix(tracer): use atomic_store for writer->headers assignment#3945
Merged
Conversation
|
writer->headers is declared _Atomic but was stored via a plain non-atomic assignment in dd_curl_set_headers, while dd_curl_reset_headers reads it with atomic_exchange. Use atomic_store to match.
b2e6e2b to
4a370a1
Compare
bwoebi
approved these changes
Jun 3, 2026
bwoebi
left a comment
Collaborator
There was a problem hiding this comment.
I surely can approve this, but atomic_store only matters when it's sequenced relative to other operations.
This shouldn't fix anything at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
writer->headersis declared_Atomicbut was being stored via a plain non-atomic assignment indd_curl_set_headers, whiledd_curl_reset_headersreads it withatomic_exchange. This replaces the plain write withatomic_storeto match.Note: the root cause of the crash in #3917 is not fully identified/fixed with this PR
Reviewer checklist