Skip to content

Normalize sample rates to 0..1#3935

Merged
bwoebi merged 1 commit into
masterfrom
bob/sampling-bounds
May 28, 2026
Merged

Normalize sample rates to 0..1#3935
bwoebi merged 1 commit into
masterfrom
bob/sampling-bounds

Conversation

@bwoebi

@bwoebi bwoebi commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Avoiding bad knuth hash computation etc.

Avoiding bad knuth hash computation etc.
@bwoebi bwoebi requested a review from a team as a code owner May 28, 2026 13:37
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented May 28, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.0, arm64]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). 7 failed tests including 'get_loaded_remote_configs' and 'get_agent_info' in shm_data_internal_fns.phpt.

DataDog/apm-reliability/dd-trace-php | min install tests   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). 3 tests failed: get_loaded_remote_configs, get_agent_info, and get_agent_sampling_config return incorrect content in shm_data_internal_fns.phpt, debugger_span_probe_class.phpt, and fleet_config.phpt.

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.5]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). 2 tests failed: 'Test dynamic config update' and 'Installing a live debugger span decoration probe'. Evaluation errors for probe id 2: Could not fetch index "val" on arg (evaluated to [foo => (stdClass){var: 2}]).

View all 9 failed jobs.

1 Test performance regression detected

testCategory from tests/Integrations/WordPress/V6_1.DDTrace\Tests\Integrations\WordPress\V6_1\PathParamsTest — 14.11s (+13.05s, +1237%)   View in Datadog

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.74% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9b043e7 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented May 28, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-05-28 14:57:53

Comparing candidate commit 9b043e7 in PR branch bob/sampling-bounds with baseline commit 217e1c7 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 193 metrics, 0 unstable metrics.

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+41.455µs; +53.818µs] or [+4.323%; +5.613%]

@bwoebi bwoebi merged commit e402ea5 into master May 28, 2026
2119 of 2129 checks passed
@bwoebi bwoebi deleted the bob/sampling-bounds branch May 28, 2026 15:00
@github-actions github-actions Bot added this to the 1.21.0 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants