Skip to content

Add block tag to rasp.rule.match#3870

Merged
cataphract merged 2 commits into
masterfrom
glopes/tel-rasp-rule-match-block
May 11, 2026
Merged

Add block tag to rasp.rule.match#3870
cataphract merged 2 commits into
masterfrom
glopes/tel-rasp-rule-match-block

Conversation

@cataphract

Copy link
Copy Markdown
Contributor

Description

Adds the missing block to appsec.rasp.rule.match metric.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract requested a review from a team as a code owner May 11, 2026 10:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7179094d84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

]]
]
])
assert overrideSup.get() != null

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Ensure the override RC version is distinct

When this phase runs in the same epoch second as the earlier applyRemoteConfig, both responses get the same version because AppSecContainer.applyRemoteConfig uses Instant.now().epochSecond; overrideSup.get() then only waits for that version and can be satisfied by the previous RC poll before the helper has consumed rasp_lfi_block_override. In that case the following request still uses the non-blocking rules and the 403/block:success assertions become flaky, so this test should force a new version or wait for evidence that the override path was actually applied.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although unlikely, I couldn't rule it out, so changed to use milliseconds instead.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented May 11, 2026

Copy link
Copy Markdown

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

❄️ Known flaky: telemetry reflects the loading of a new integration() from com.datadog.appsec.php.integration.TelemetryTests   View in Datadog   (Fix with Cursor)
Assertion failed: 

assert !foundRedis
       ||
       |true
       false

Assertion failed: 

assert !foundRedis
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.68% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7a45f18 | Docs | Datadog PR Page | Give us feedback!

@cataphract cataphract merged commit 7bb186d into master May 11, 2026
2113 of 2121 checks passed
@cataphract cataphract deleted the glopes/tel-rasp-rule-match-block branch May 11, 2026 17:11
@github-actions github-actions Bot added this to the 1.20.0 milestone May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants