Skip to content

Fix instanceof type aliases for PHP 7.x in live debugger DSL #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bwoebi merged 1 commit into from
Apr 22, 2026
Merged

Fix instanceof type aliases for PHP 7.x in live debugger DSL #3813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ext/live_debugger.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,7 +1591,19 @@ static bool dd_eval_instanceof(void *ctx, const void *zvp, const ddog_CharSlice
{
name = zend_zval_type_name(zv);
}
return zend_binary_strcasecmp(name, strlen(name), class->ptr, class->len) == 0;
if (zend_binary_strcasecmp(name, strlen(name), class->ptr, class->len) == 0) {
return true;
}
// PHP 7.x returns "integer"/"double"; normalize aliases for DSL compatibility
if (Z_TYPE_P(zv) == IS_LONG) {
return zend_binary_strcasecmp(ZEND_STRL("int"), class->ptr, class->len) == 0
|| zend_binary_strcasecmp(ZEND_STRL("integer"), class->ptr, class->len) == 0;
}
if (Z_TYPE_P(zv) == IS_DOUBLE) {
return zend_binary_strcasecmp(ZEND_STRL("float"), class->ptr, class->len) == 0
|| zend_binary_strcasecmp(ZEND_STRL("double"), class->ptr, class->len) == 0;
}
return false;
}

const ddog_Evaluator dd_evaluator = {
Expand Down
Loading