Skip to content

ensure __GLIBC__ properly defined before using it#353

Merged
pawelchcki merged 1 commit into
DataDog:masterfrom
remicollet:issue-glibc
Mar 13, 2019
Merged

ensure __GLIBC__ properly defined before using it#353
pawelchcki merged 1 commit into
DataDog:masterfrom
remicollet:issue-glibc

Conversation

@remicollet

Copy link
Copy Markdown
Contributor

Discovered while working a a build warning

/dev/shm/BUILD/php-pecl-datadog-trace-0.15.1/NTS/src/ext/backtrace.c:54:6: warning: type of 'TSRMLS_D' defaults to 'int' [-Wimplicit-int]
 void ddtrace_install_backtrace_handler(TSRMLS_D) {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Tracking this issue, the bas code is selected as GLIBC is tested before all include, where it is defined.

@SammyK SammyK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR @remicollet! I wan't able to get it to compile in the containers until I moved the #include <execinfo.h> line inside the ifdef. If you can make that tweak, I'll merge. Thanks again for the contribution! :)

Comment thread src/ext/backtrace.c Outdated
@remicollet

Copy link
Copy Markdown
Contributor Author

It seems github have very strange behavior... BTW, requested change is done

@SammyK

SammyK commented Mar 12, 2019

Copy link
Copy Markdown
Contributor

Thanks @remicollet! :) Yeah, apparently there's some issues with GitHub at the moment.

@pawelchcki pawelchcki merged commit 29438ce into DataDog:master Mar 13, 2019
@remicollet remicollet deleted the issue-glibc branch March 13, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants