ensure __GLIBC__ properly defined before using it#353
Merged
Conversation
SammyK
suggested changes
Mar 12, 2019
SammyK
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much for the PR @remicollet! I wan't able to get it to compile in the containers until I moved the #include <execinfo.h> line inside the ifdef. If you can make that tweak, I'll merge. Thanks again for the contribution! :)
Contributor
Author
|
It seems github have very strange behavior... BTW, requested change is done |
SammyK
approved these changes
Mar 12, 2019
Contributor
|
Thanks @remicollet! :) Yeah, apparently there's some issues with GitHub at the moment. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working a a build warning
Tracking this issue, the bas code is selected as GLIBC is tested before all include, where it is defined.