Group vertx instrumentations by amarziali · Pull Request #9529 · DataDog/dd-trace-java

amarziali · 2025-09-15T09:34:34Z

What Does This Do

This PR creates the following grade modules:

a vertx super module
vertx-mysql-client
vertx-pg-client
vertx-web

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-09-15T09:54:02Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 60.14% (-0.02%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 0733642 | Docs | Was this helpful? Give us feedback!}

PerfectSlayer

👏 praise: ‏Thanks for the refactoring!

pr-commenter · 2025-09-15T10:07:05Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/vertx
git_commit_date	1757946373	1757947655
git_commit_sha	`8f4fb42`	`0733642`
release_version	1.54.0-SNAPSHOT~8f4fb427ca	1.54.0-SNAPSHOT~07336424b5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757949646	1757949646
ci_job_id	1129234325	1129234325
ci_pipeline_id	76488581	76488581
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-f0zwnepj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-f0zwnepj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057964
Total [baseline] (10.647 s) : 0, 10647097
Agent [candidate] (1.061 s) : 0, 1060725
Total [candidate] (10.668 s) : 0, 10668417
section appsec
Agent [baseline] (1.233 s) : 0, 1233268
Total [baseline] (11.034 s) : 0, 11033996
Agent [candidate] (1.236 s) : 0, 1236452
Total [candidate] (10.886 s) : 0, 10886090
section iast
Agent [baseline] (1.19 s) : 0, 1189971
Total [baseline] (11.003 s) : 0, 11003448
Agent [candidate] (1.19 s) : 0, 1190463
Total [candidate] (11.052 s) : 0, 11051906
section profiling
Agent [baseline] (1.215 s) : 0, 1215064
Total [baseline] (10.969 s) : 0, 10968775
Agent [candidate] (1.211 s) : 0, 1210656
Total [candidate] (10.97 s) : 0, 10969724

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.233 s	175.303 ms (16.6%)
Agent	iast	1.19 s	132.006 ms (12.5%)
Agent	profiling	1.215 s	157.1 ms (14.8%)
Total	tracing	10.647 s	-
Total	appsec	11.034 s	386.899 ms (3.6%)
Total	iast	11.003 s	356.351 ms (3.3%)
Total	profiling	10.969 s	321.679 ms (3.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.236 s	175.727 ms (16.6%)
Agent	iast	1.19 s	129.738 ms (12.2%)
Agent	profiling	1.211 s	149.931 ms (14.1%)
Total	tracing	10.668 s	-
Total	appsec	10.886 s	217.673 ms (2.0%)
Total	iast	11.052 s	383.488 ms (3.6%)
Total	profiling	10.97 s	301.307 ms (2.8%)

gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (729.808 ms) : 0, 729808
BytebuddyAgent [candidate] (732.821 ms) : 0, 732821
GlobalTracer [baseline] (251.756 ms) : 0, 251756
GlobalTracer [candidate] (252.325 ms) : 0, 252325
AppSec [baseline] (30.527 ms) : 0, 30527
AppSec [candidate] (30.484 ms) : 0, 30484
Debugger [baseline] (6.34 ms) : 0, 6340
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (692.544 µs) : 0, 693
Remote Config [candidate] (692.343 µs) : 0, 692
Telemetry [baseline] (16.301 ms) : 0, 16301
Telemetry [candidate] (15.367 ms) : 0, 15367
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (754.561 ms) : 0, 754561
BytebuddyAgent [candidate] (757.719 ms) : 0, 757719
GlobalTracer [baseline] (245.019 ms) : 0, 245019
GlobalTracer [candidate] (245.61 ms) : 0, 245610
IAST [baseline] (23.806 ms) : 0, 23806
IAST [candidate] (23.848 ms) : 0, 23848
AppSec [baseline] (172.022 ms) : 0, 172022
AppSec [candidate] (171.625 ms) : 0, 171625
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (5.994 ms) : 0, 5994
Remote Config [baseline] (620.323 µs) : 0, 620
Remote Config [candidate] (631.204 µs) : 0, 631
Telemetry [baseline] (8.51 ms) : 0, 8510
Telemetry [candidate] (8.348 ms) : 0, 8348
section iast
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (851.789 ms) : 0, 851789
BytebuddyAgent [candidate] (851.656 ms) : 0, 851656
GlobalTracer [baseline] (247.189 ms) : 0, 247189
GlobalTracer [candidate] (246.812 ms) : 0, 246812
IAST [baseline] (28.818 ms) : 0, 28818
IAST [candidate] (26.372 ms) : 0, 26372
AppSec [baseline] (24.849 ms) : 0, 24849
AppSec [candidate] (28.141 ms) : 0, 28141
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.05 ms) : 0, 6050
Remote Config [baseline] (603.354 µs) : 0, 603
Remote Config [candidate] (617.879 µs) : 0, 618
Telemetry [baseline] (8.159 ms) : 0, 8159
Telemetry [candidate] (8.309 ms) : 0, 8309
section profiling
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (765.754 ms) : 0, 765754
BytebuddyAgent [candidate] (763.151 ms) : 0, 763151
GlobalTracer [baseline] (233.448 ms) : 0, 233448
GlobalTracer [candidate] (232.804 ms) : 0, 232804
AppSec [baseline] (30.554 ms) : 0, 30554
AppSec [candidate] (30.384 ms) : 0, 30384
Debugger [baseline] (8.956 ms) : 0, 8956
Debugger [candidate] (7.483 ms) : 0, 7483
Remote Config [baseline] (738.801 µs) : 0, 739
Remote Config [candidate] (699.95 µs) : 0, 700
Telemetry [baseline] (14.15 ms) : 0, 14150
Telemetry [candidate] (15.848 ms) : 0, 15848
ProfilingAgent [baseline] (108.651 ms) : 0, 108651
ProfilingAgent [candidate] (107.633 ms) : 0, 107633
Profiling [baseline] (109.294 ms) : 0, 109294
Profiling [candidate] (108.286 ms) : 0, 108286

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063167
Total [baseline] (8.676 s) : 0, 8676247
Agent [candidate] (1.074 s) : 0, 1074458
Total [candidate] (8.655 s) : 0, 8654571
section iast
Agent [baseline] (1.189 s) : 0, 1189345
Total [baseline] (9.354 s) : 0, 9354365
Agent [candidate] (1.186 s) : 0, 1186453
Total [candidate] (9.259 s) : 0, 9258991

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.189 s	126.178 ms (11.9%)
Total	tracing	8.676 s	-
Total	iast	9.354 s	678.118 ms (7.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.074 s	-
Agent	iast	1.186 s	111.995 ms (10.4%)
Total	tracing	8.655 s	-
Total	iast	9.259 s	604.421 ms (7.0%)

gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (734.443 ms) : 0, 734443
BytebuddyAgent [candidate] (741.765 ms) : 0, 741765
GlobalTracer [baseline] (252.546 ms) : 0, 252546
GlobalTracer [candidate] (255.284 ms) : 0, 255284
AppSec [baseline] (30.701 ms) : 0, 30701
AppSec [candidate] (31.218 ms) : 0, 31218
Debugger [baseline] (6.375 ms) : 0, 6375
Debugger [candidate] (6.527 ms) : 0, 6527
Remote Config [baseline] (699.275 µs) : 0, 699
Remote Config [candidate] (707.028 µs) : 0, 707
Telemetry [baseline] (15.757 ms) : 0, 15757
Telemetry [candidate] (16.216 ms) : 0, 16216
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (851.734 ms) : 0, 851734
BytebuddyAgent [candidate] (849.905 ms) : 0, 849905
GlobalTracer [baseline] (246.932 ms) : 0, 246932
GlobalTracer [candidate] (244.684 ms) : 0, 244684
AppSec [baseline] (24.87 ms) : 0, 24870
AppSec [candidate] (24.552 ms) : 0, 24552
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (6.054 ms) : 0, 6054
Remote Config [baseline] (610.019 µs) : 0, 610
Remote Config [candidate] (585.967 µs) : 0, 586
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.059 ms) : 0, 8059
IAST [baseline] (28.601 ms) : 0, 28601
IAST [candidate] (30.259 ms) : 0, 30259

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/vertx
git_commit_date	1757946373	1757947655
git_commit_sha	`8f4fb42`	`0733642`
release_version	1.54.0-SNAPSHOT~8f4fb427ca	1.54.0-SNAPSHOT~07336424b5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1757949305	1757949305
ci_job_id	1129234328	1129234328
ci_pipeline_id	76488581	76488581
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-z4lo3aen 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-z4lo3aen 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	better [-482.073µs; -230.349µs] or [-6.003%; -2.869%]	unstable [-48.719op/s; +102.156op/s] or [-8.446%; +17.710%]	7.674ms	603.562op/s	8.030ms	576.844op/s
scenario:load:petclinic:tracing:high_load	worse [+2.534ms; +3.387ms] or [+5.792%; +7.742%]	unstable [-13.686op/s; +0.161op/s] or [-12.799%; +0.150%]	46.706ms	100.162op/s	43.745ms	106.925op/s
scenario:load:petclinic:appsec:high_load	better [-2.026ms; -1.099ms] or [-4.040%; -2.190%]	unstable [-3.261op/s; +9.261op/s] or [-3.496%; +9.928%]	48.601ms	96.275op/s	50.163ms	93.275op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.507 ms) : 37205, 37810
.   : milestone, 37507,
appsec (50.163 ms) : 49729, 50597
.   : milestone, 50163,
code_origins (45.906 ms) : 45503, 46309
.   : milestone, 45906,
iast (43.332 ms) : 42956, 43708
.   : milestone, 43332,
profiling (48.636 ms) : 48179, 49094
.   : milestone, 48636,
tracing (43.745 ms) : 43374, 44117
.   : milestone, 43745,
section candidate
no_agent (37.246 ms) : 36942, 37550
.   : milestone, 37246,
appsec (48.601 ms) : 48173, 49029
.   : milestone, 48601,
code_origins (46.148 ms) : 45732, 46563
.   : milestone, 46148,
iast (42.746 ms) : 42380, 43112
.   : milestone, 42746,
profiling (49.167 ms) : 48670, 49663
.   : milestone, 49167,
tracing (46.706 ms) : 46285, 47126
.   : milestone, 46706,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.507 ms [37.205 ms, 37.81 ms]	-
appsec	50.163 ms [49.729 ms, 50.597 ms]	12.656 ms (33.7%)
code_origins	45.906 ms [45.503 ms, 46.309 ms]	8.399 ms (22.4%)
iast	43.332 ms [42.956 ms, 43.708 ms]	5.825 ms (15.5%)
profiling	48.636 ms [48.179 ms, 49.094 ms]	11.129 ms (29.7%)
tracing	43.745 ms [43.374 ms, 44.117 ms]	6.238 ms (16.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.246 ms [36.942 ms, 37.55 ms]	-
appsec	48.601 ms [48.173 ms, 49.029 ms]	11.355 ms (30.5%)
code_origins	46.148 ms [45.732 ms, 46.563 ms]	8.902 ms (23.9%)
iast	42.746 ms [42.38 ms, 43.112 ms]	5.5 ms (14.8%)
profiling	49.167 ms [48.67 ms, 49.663 ms]	11.921 ms (32.0%)
tracing	46.706 ms [46.285 ms, 47.126 ms]	9.46 ms (25.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.306 ms) : 4257, 4355
.   : milestone, 4306,
iast (9.319 ms) : 9167, 9471
.   : milestone, 9319,
iast_FULL (14.204 ms) : 13919, 14489
.   : milestone, 14204,
iast_GLOBAL (10.236 ms) : 10043, 10429
.   : milestone, 10236,
profiling (8.897 ms) : 8757, 9038
.   : milestone, 8897,
tracing (8.03 ms) : 7914, 8147
.   : milestone, 8030,
section candidate
no_agent (4.422 ms) : 4365, 4480
.   : milestone, 4422,
iast (9.404 ms) : 9249, 9558
.   : milestone, 9404,
iast_FULL (14.327 ms) : 14039, 14614
.   : milestone, 14327,
iast_GLOBAL (10.211 ms) : 10033, 10389
.   : milestone, 10211,
profiling (9.023 ms) : 8883, 9162
.   : milestone, 9023,
tracing (7.674 ms) : 7556, 7791
.   : milestone, 7674,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.306 ms [4.257 ms, 4.355 ms]	-
iast	9.319 ms [9.167 ms, 9.471 ms]	5.013 ms (116.4%)
iast_FULL	14.204 ms [13.919 ms, 14.489 ms]	9.898 ms (229.9%)
iast_GLOBAL	10.236 ms [10.043 ms, 10.429 ms]	5.929 ms (137.7%)
profiling	8.897 ms [8.757 ms, 9.038 ms]	4.591 ms (106.6%)
tracing	8.03 ms [7.914 ms, 8.147 ms]	3.724 ms (86.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.422 ms [4.365 ms, 4.48 ms]	-
iast	9.404 ms [9.249 ms, 9.558 ms]	4.981 ms (112.6%)
iast_FULL	14.327 ms [14.039 ms, 14.614 ms]	9.905 ms (224.0%)
iast_GLOBAL	10.211 ms [10.033 ms, 10.389 ms]	5.789 ms (130.9%)
profiling	9.023 ms [8.883 ms, 9.162 ms]	4.6 ms (104.0%)
tracing	7.674 ms [7.556 ms, 7.791 ms]	3.252 ms (73.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/vertx
git_commit_date	1757946373	1757947655
git_commit_sha	`8f4fb42`	`0733642`
release_version	1.54.0-SNAPSHOT~8f4fb427ca	1.54.0-SNAPSHOT~07336424b5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1757949831	1757949831
ci_job_id	1129234331	1129234331
ci_pipeline_id	76488581	76488581
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-legxdrqz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-legxdrqz 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1490
.   : milestone, 1478,
appsec (3.683 ms) : 3465, 3901
.   : milestone, 3683,
iast (2.195 ms) : 2132, 2257
.   : milestone, 2195,
iast_GLOBAL (2.231 ms) : 2168, 2294
.   : milestone, 2231,
profiling (2.058 ms) : 2006, 2110
.   : milestone, 2058,
tracing (2.017 ms) : 1969, 2066
.   : milestone, 2017,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.698 ms) : 3481, 3915
.   : milestone, 3698,
iast (2.185 ms) : 2122, 2247
.   : milestone, 2185,
iast_GLOBAL (2.234 ms) : 2172, 2297
.   : milestone, 2234,
profiling (2.04 ms) : 1990, 2091
.   : milestone, 2040,
tracing (2.017 ms) : 1968, 2066
.   : milestone, 2017,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.49 ms]	-
appsec	3.683 ms [3.465 ms, 3.901 ms]	2.205 ms (149.2%)
iast	2.195 ms [2.132 ms, 2.257 ms]	716.504 µs (48.5%)
iast_GLOBAL	2.231 ms [2.168 ms, 2.294 ms]	752.675 µs (50.9%)
profiling	2.058 ms [2.006 ms, 2.11 ms]	580.296 µs (39.3%)
tracing	2.017 ms [1.969 ms, 2.066 ms]	539.288 µs (36.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.472 ms [1.46 ms, 1.483 ms]	-
appsec	3.698 ms [3.481 ms, 3.915 ms]	2.226 ms (151.2%)
iast	2.185 ms [2.122 ms, 2.247 ms]	712.715 µs (48.4%)
iast_GLOBAL	2.234 ms [2.172 ms, 2.297 ms]	762.327 µs (51.8%)
profiling	2.04 ms [1.99 ms, 2.091 ms]	568.108 µs (38.6%)
tracing	2.017 ms [1.968 ms, 2.066 ms]	545.02 µs (37.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~07336424b5, baseline=1.54.0-SNAPSHOT~8f4fb427ca
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.95 s) : 14950000, 14950000
.   : milestone, 14950000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.325 s) : 18325000, 18325000
.   : milestone, 18325000,
iast_GLOBAL (17.554 s) : 17554000, 17554000
.   : milestone, 17554000,
profiling (15.679 s) : 15679000, 15679000
.   : milestone, 15679000,
tracing (14.856 s) : 14856000, 14856000
.   : milestone, 14856000,
section candidate
no_agent (15.493 s) : 15493000, 15493000
.   : milestone, 15493000,
appsec (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
iast (18.715 s) : 18715000, 18715000
.   : milestone, 18715000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
.   : milestone, 18252000,
profiling (15.511 s) : 15511000, 15511000
.   : milestone, 15511000,
tracing (14.836 s) : 14836000, 14836000
.   : milestone, 14836000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.95 s [14.95 s, 14.95 s]	-
appsec	14.998 s [14.998 s, 14.998 s]	48.0 ms (0.3%)
iast	18.325 s [18.325 s, 18.325 s]	3.375 s (22.6%)
iast_GLOBAL	17.554 s [17.554 s, 17.554 s]	2.604 s (17.4%)
profiling	15.679 s [15.679 s, 15.679 s]	729.0 ms (4.9%)
tracing	14.856 s [14.856 s, 14.856 s]	-94.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.493 s [15.493 s, 15.493 s]	-
appsec	15.004 s [15.004 s, 15.004 s]	-489.0 ms (-3.2%)
iast	18.715 s [18.715 s, 18.715 s]	3.222 s (20.8%)
iast_GLOBAL	18.252 s [18.252 s, 18.252 s]	2.759 s (17.8%)
profiling	15.511 s [15.511 s, 15.511 s]	18.0 ms (0.1%)
tracing	14.836 s [14.836 s, 14.836 s]	-657.0 ms (-4.2%)

manuel-alvarez-alvarez

LGTM

amarziali · 2025-09-15T12:24:39Z

 import io.vertx.redis.client.Response;
-import io.vertx.redis.client.impl.RequestImpl;
 import net.bytebuddy.asm.Advice;
+import vertx.redis.client.impl.RequestImpl;


curiously IntelliJ changed me those imports with the move (why ? 🤌 ) so the advices stopped working as expected

Group vertx instrumentations

5cf85ec

amarziali added the tag: no release notes Changes to exclude from release notes label Sep 15, 2025

amarziali requested review from a team as code owners September 15, 2025 09:34

amarziali added type: refactoring inst: vertx Eclipse Vert.x instrumentation labels Sep 15, 2025

amarziali requested review from sezen-datadog and smola September 15, 2025 09:34

amarziali enabled auto-merge (squash) September 15, 2025 09:35

PerfectSlayer approved these changes Sep 15, 2025

View reviewed changes

manuel-alvarez-alvarez approved these changes Sep 15, 2025

View reviewed changes

amarziali commented Sep 15, 2025

View reviewed changes

Revert changes done by the IDE

0733642

amarziali force-pushed the andrea.marziali/vertx branch from 8142500 to 0733642 Compare September 15, 2025 14:47

amarziali merged commit 82c053b into master Sep 15, 2025
498 checks passed

amarziali deleted the andrea.marziali/vertx branch September 15, 2025 15:45

github-actions Bot added this to the 1.54.0 milestone Sep 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Group vertx instrumentations#9529

Group vertx instrumentations#9529
amarziali merged 2 commits into
masterfrom
andrea.marziali/vertx

amarziali commented Sep 15, 2025

Uh oh!

datadog-datadog-prod-us1 Bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

pr-commenter Bot commented Sep 15, 2025 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez left a comment

Uh oh!

amarziali Sep 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amarziali commented Sep 15, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 Bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

pr-commenter Bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

Uh oh!

amarziali Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-datadog-prod-us1 Bot commented Sep 15, 2025 •

edited

Loading

pr-commenter Bot commented Sep 15, 2025 •

edited

Loading