Support all value for DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED#8598
Merged
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039171
Total [baseline] (8.672 s) : 0, 8671680
Agent [candidate] (1.042 s) : 0, 1042041
Total [candidate] (8.687 s) : 0, 8686768
section iast
Agent [baseline] (1.171 s) : 0, 1171380
Total [baseline] (9.248 s) : 0, 9247952
Agent [candidate] (1.178 s) : 0, 1178297
Total [candidate] (9.274 s) : 0, 9273928
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171618
Total [baseline] (9.184 s) : 0, 9184394
Agent [candidate] (1.178 s) : 0, 1178383
Total [candidate] (9.234 s) : 0, 9234320
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171335
Total [baseline] (9.219 s) : 0, 9219496
Agent [candidate] (1.169 s) : 0, 1169016
Total [candidate] (9.246 s) : 0, 9246477
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.768 ms) : 0, 716768
BytebuddyAgent [candidate] (718.785 ms) : 0, 718785
GlobalTracer [baseline] (238.813 ms) : 0, 238813
GlobalTracer [candidate] (239.862 ms) : 0, 239862
AppSec [baseline] (54.699 ms) : 0, 54699
AppSec [candidate] (54.572 ms) : 0, 54572
Remote Config [baseline] (706.654 µs) : 0, 707
Remote Config [candidate] (684.007 µs) : 0, 684
Telemetry [baseline] (12.258 ms) : 0, 12258
Telemetry [candidate] (12.129 ms) : 0, 12129
section iast
BytebuddyAgent [baseline] (837.455 ms) : 0, 837455
BytebuddyAgent [candidate] (841.843 ms) : 0, 841843
GlobalTracer [baseline] (230.111 ms) : 0, 230111
GlobalTracer [candidate] (231.409 ms) : 0, 231409
IAST [baseline] (22.745 ms) : 0, 22745
IAST [candidate] (22.896 ms) : 0, 22896
AppSec [baseline] (55.81 ms) : 0, 55810
AppSec [candidate] (56.77 ms) : 0, 56770
Remote Config [baseline] (609.19 µs) : 0, 609
Remote Config [candidate] (615.459 µs) : 0, 615
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.768 ms) : 0, 8768
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.19 ms) : 0, 837190
BytebuddyAgent [candidate] (842.525 ms) : 0, 842525
GlobalTracer [baseline] (230.068 ms) : 0, 230068
GlobalTracer [candidate] (230.913 ms) : 0, 230913
IAST [baseline] (22.996 ms) : 0, 22996
IAST [candidate] (23.222 ms) : 0, 23222
AppSec [baseline] (56.117 ms) : 0, 56117
AppSec [candidate] (56.305 ms) : 0, 56305
Remote Config [baseline] (612.598 µs) : 0, 613
Remote Config [candidate] (614.448 µs) : 0, 614
Telemetry [baseline] (8.666 ms) : 0, 8666
Telemetry [candidate] (8.727 ms) : 0, 8727
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.293 ms) : 0, 837293
BytebuddyAgent [candidate] (834.786 ms) : 0, 834786
GlobalTracer [baseline] (230.686 ms) : 0, 230686
GlobalTracer [candidate] (230.63 ms) : 0, 230630
IAST [baseline] (22.353 ms) : 0, 22353
IAST [candidate] (22.383 ms) : 0, 22383
AppSec [baseline] (55.713 ms) : 0, 55713
AppSec [candidate] (55.926 ms) : 0, 55926
Remote Config [baseline] (605.132 µs) : 0, 605
Remote Config [candidate] (601.915 µs) : 0, 602
Telemetry [baseline] (8.642 ms) : 0, 8642
Telemetry [candidate] (8.601 ms) : 0, 8601
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046142
Total [baseline] (10.5 s) : 0, 10499858
Agent [candidate] (1.041 s) : 0, 1041270
Total [candidate] (10.445 s) : 0, 10444507
section appsec
Agent [baseline] (1.192 s) : 0, 1191543
Total [baseline] (10.771 s) : 0, 10770795
Agent [candidate] (1.186 s) : 0, 1186450
Total [candidate] (10.726 s) : 0, 10726429
section iast
Agent [baseline] (1.172 s) : 0, 1171894
Total [baseline] (10.978 s) : 0, 10978337
Agent [candidate] (1.17 s) : 0, 1170153
Total [candidate] (11.033 s) : 0, 11032786
section profiling
Agent [baseline] (1.263 s) : 0, 1263255
Total [baseline] (10.813 s) : 0, 10813205
Agent [candidate] (1.261 s) : 0, 1261145
Total [candidate] (10.849 s) : 0, 10849006
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.134 ms) : 0, 721134
BytebuddyAgent [candidate] (717.624 ms) : 0, 717624
GlobalTracer [baseline] (240.634 ms) : 0, 240634
GlobalTracer [candidate] (239.513 ms) : 0, 239513
AppSec [baseline] (54.668 ms) : 0, 54668
AppSec [candidate] (54.61 ms) : 0, 54610
Remote Config [baseline] (691.874 µs) : 0, 692
Remote Config [candidate] (685.39 µs) : 0, 685
Telemetry [baseline] (12.895 ms) : 0, 12895
Telemetry [candidate] (12.867 ms) : 0, 12867
section appsec
BytebuddyAgent [baseline] (741.216 ms) : 0, 741216
BytebuddyAgent [candidate] (737.767 ms) : 0, 737767
GlobalTracer [baseline] (237.441 ms) : 0, 237441
GlobalTracer [candidate] (237.021 ms) : 0, 237021
AppSec [baseline] (176.616 ms) : 0, 176616
AppSec [candidate] (175.88 ms) : 0, 175880
Remote Config [baseline] (660.882 µs) : 0, 661
Remote Config [candidate] (663.382 µs) : 0, 663
Telemetry [baseline] (8.675 ms) : 0, 8675
Telemetry [candidate] (8.299 ms) : 0, 8299
IAST [baseline] (21.717 ms) : 0, 21717
IAST [candidate] (21.684 ms) : 0, 21684
section iast
BytebuddyAgent [baseline] (838.02 ms) : 0, 838020
BytebuddyAgent [candidate] (836.149 ms) : 0, 836149
GlobalTracer [baseline] (229.873 ms) : 0, 229873
GlobalTracer [candidate] (229.76 ms) : 0, 229760
AppSec [baseline] (56.024 ms) : 0, 56024
AppSec [candidate] (56.128 ms) : 0, 56128
Remote Config [baseline] (612.921 µs) : 0, 613
Remote Config [candidate] (607.31 µs) : 0, 607
Telemetry [baseline] (8.61 ms) : 0, 8610
Telemetry [candidate] (8.665 ms) : 0, 8665
IAST [baseline] (22.889 ms) : 0, 22889
IAST [candidate] (22.931 ms) : 0, 22931
section profiling
ProfilingAgent [baseline] (96.735 ms) : 0, 96735
ProfilingAgent [candidate] (96.416 ms) : 0, 96416
BytebuddyAgent [baseline] (710.765 ms) : 0, 710765
BytebuddyAgent [candidate] (709.821 ms) : 0, 709821
GlobalTracer [baseline] (350.214 ms) : 0, 350214
GlobalTracer [candidate] (349.948 ms) : 0, 349948
AppSec [baseline] (54.475 ms) : 0, 54475
AppSec [candidate] (53.75 ms) : 0, 53750
Remote Config [baseline] (715.455 µs) : 0, 715
Remote Config [candidate] (713.529 µs) : 0, 714
Telemetry [baseline] (8.864 ms) : 0, 8864
Telemetry [candidate] (8.93 ms) : 0, 8930
Profiling [baseline] (96.759 ms) : 0, 96759
Profiling [candidate] (96.439 ms) : 0, 96439
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section baseline
no_agent (380.626 µs) : 361, 400
. : milestone, 381,
iast (509.065 µs) : 488, 530
. : milestone, 509,
iast_FULL (730.96 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (561.752 µs) : 539, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (514.763 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (465.214 µs) : 443, 488
. : milestone, 465,
iast_TELEMETRY_OFF (498.773 µs) : 476, 521
. : milestone, 499,
tracing (455.947 µs) : 435, 477
. : milestone, 456,
section candidate
no_agent (378.048 µs) : 359, 397
. : milestone, 378,
iast (508.432 µs) : 487, 530
. : milestone, 508,
iast_FULL (730.399 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (550.159 µs) : 529, 572
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (509.052 µs) : 487, 531
. : milestone, 509,
iast_INACTIVE (466.12 µs) : 445, 488
. : milestone, 466,
iast_TELEMETRY_OFF (503.517 µs) : 481, 526
. : milestone, 504,
tracing (454.246 µs) : 434, 475
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.731 ms) : 1707, 1754
. : milestone, 1731,
appsec_no_iast (1.725 ms) : 1699, 1750
. : milestone, 1725,
code_origins (1.68 ms) : 1653, 1708
. : milestone, 1680,
iast (1.497 ms) : 1473, 1520
. : milestone, 1497,
profiling (1.501 ms) : 1477, 1524
. : milestone, 1501,
tracing (1.482 ms) : 1457, 1507
. : milestone, 1482,
section candidate
no_agent (1.356 ms) : 1337, 1376
. : milestone, 1356,
appsec (1.731 ms) : 1707, 1754
. : milestone, 1731,
appsec_no_iast (1.708 ms) : 1683, 1733
. : milestone, 1708,
code_origins (1.668 ms) : 1641, 1694
. : milestone, 1668,
iast (1.514 ms) : 1490, 1538
. : milestone, 1514,
profiling (1.529 ms) : 1505, 1553
. : milestone, 1529,
tracing (1.485 ms) : 1460, 1510
. : milestone, 1485,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.369 ms) : 2325, 2413
. : milestone, 2369,
iast (2.14 ms) : 2084, 2196
. : milestone, 2140,
iast_GLOBAL (2.177 ms) : 2121, 2233
. : milestone, 2177,
profiling (1.986 ms) : 1942, 2030
. : milestone, 1986,
tracing (1.975 ms) : 1932, 2018
. : milestone, 1975,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (2.358 ms) : 2314, 2402
. : milestone, 2358,
iast (2.139 ms) : 2083, 2195
. : milestone, 2139,
iast_GLOBAL (2.179 ms) : 2123, 2235
. : milestone, 2179,
profiling (1.986 ms) : 1942, 2030
. : milestone, 1986,
tracing (1.965 ms) : 1923, 2008
. : milestone, 1965,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~441f6c9a4f, baseline=1.48.0-SNAPSHOT~efdcea8304
dateFormat X
axisFormat %s
section baseline
no_agent (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
appsec (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
iast (19.007 s) : 19007000, 19007000
. : milestone, 19007000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
. : milestone, 17878000,
profiling (15.153 s) : 15153000, 15153000
. : milestone, 15153000,
tracing (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
section candidate
no_agent (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
appsec (14.901 s) : 14901000, 14901000
. : milestone, 14901000,
iast (18.943 s) : 18943000, 18943000
. : milestone, 18943000,
iast_GLOBAL (18.002 s) : 18002000, 18002000
. : milestone, 18002000,
profiling (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
tracing (14.951 s) : 14951000, 14951000
. : milestone, 14951000,
|
all value for experimentalFeaturesEnabled
all value for experimentalFeaturesEnabledall value for DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED
mhlidd
marked this pull request as ready for review
March 20, 2025 20:32
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
amarziali
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
DD_TRACE_EXPERIMENTAL_FEATURES_ENABLEDsupports the valueall, where we enable all "breaking change" configs. All future breaking change configs should update theDEFAULT_TRACE_EXPERIMENTAL_FEATURES_ENABLED, as the all value falls back on that value.Motivation
RFC
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]