Skip to content

Do not automatically enable ddprof for J9 JDK 11/17 #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 1 commit into from
Apr 17, 2023
Merged

Do not automatically enable ddprof for J9 JDK 11/17 #5072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions internal-api/src/main/java/datadog/trace/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,11 +1916,23 @@ public static boolean isDatadogProfilerSafeInCurrentEnvironment() {
// don't want to put this logic (which will evolve) in the public ProfilingConfig, and can't
// access Platform there
// we encountered AsyncGetCallTrace bugs when ZGC is enabled
return Platform.activeGarbageCollector() != Z
&& (Platform.isJ9()
|| Platform.isJavaVersionAtLeast(17, 0, 5)
|| (Platform.isJavaVersion(11) && Platform.isJavaVersionAtLeast(11, 0, 17))
|| (Platform.isJavaVersion(8) && Platform.isJavaVersionAtLeast(8, 0, 352)));

boolean result =
Platform.activeGarbageCollector() != Z
&& (Platform.isJ9()
|| Platform.isJavaVersionAtLeast(17, 0, 5)
|| (Platform.isJavaVersion(11) && Platform.isJavaVersionAtLeast(11, 0, 17))
|| (Platform.isJavaVersion(8) && Platform.isJavaVersionAtLeast(8, 0, 352)));

if (result && Platform.isJ9()) {
// Semeru JDK 11 and JDK 17 have problems with unloaded classes and jmethodids, leading to JVM
// crash
// The ASGCT based profilers are only activated in JDK 11.0.18+ and JDK 17.0.6+
result &=
!((Platform.isJavaVersion(11) && Platform.isJavaVersionAtLeast(11, 0, 18))
|| ((Platform.isJavaVersion(17) && Platform.isJavaVersionAtLeast(17, 0, 6))));
}
return result;
}

public boolean isCrashTrackingAgentless() {
Expand Down