Remove SummaryBuilder interface#5030
Merged
Merged
Conversation
jpbempel
added
tag: no release notes
jpbempel
force-pushed
the
jpbempel/refacto-log-template-builder
branch
from
April 5, 2023 06:21
8f26b6b to
7df2913
Compare
Changing LogTemplateBuilder api use directly LogTemplateBuilder into LogProbe during evaluation
jpbempel
force-pushed
the
jpbempel/refacto-log-template-builder
branch
from
April 6, 2023 09:24
7df2913 to
9eea387
Compare
shatzi
approved these changes
Apr 10, 2023
shatzi
left a comment
shatzi
left a comment
Contributor
There was a problem hiding this comment.
This is great. thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Changing LogTemplateBuilder api
use directly LogTemplateBuilder into LogProbe during evaluation
Motivation
Summary was removed no need to keep the SummaryBuilder interface
Additional Notes