[6to7] Add malformed_tid and inconsistent_tid decoding error support#5028
Merged
Conversation
PerfectSlayer
commented
Apr 5, 2023
Comment on lines
698
to
704
Contributor
Author
There was a problem hiding this comment.
@bantonsson I wonder if error field would not be better stored in PTags class now errors can be handled from elsewhere than PTagsWithError.
The PtagsWithError would become a static factory method from PTags instead: PTags.withError(String).
WDYT?
bantonsson
approved these changes
Apr 5, 2023
bantonsson
left a comment
bantonsson
left a comment
Contributor
There was a problem hiding this comment.
👍🏻 on moving the error field
PerfectSlayer
force-pushed
the
bbujon/128b-traceid-ptags
branch
from
April 5, 2023 08:16
dcdcbbd to
ea834d5
Compare
PerfectSlayer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add
malformed_tidandinconsistent_tiddecoding error support from propagation tags.Motivation
Additional Notes