Add span decoration config#4998
Merged
Merged
Conversation
Add support for decorating current active or root span with dynamic tag values taken from the context where the probe is set. Adding the tag can also depend on condition
shatzi
approved these changes
Mar 30, 2023
| } | ||
| addMetricProbes(other.getMetricProbes()); | ||
| addLogProbes(other.getLogProbes()); | ||
| addSpanProbes(other.getSpanProbes()); |
Contributor
There was a problem hiding this comment.
do we need this function? as we removed support for service configuration maybe we can drop this?
Member
Author
There was a problem hiding this comment.
yeah will remove it in a next PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add support for decorating current active or root span with dynamic tag values taken from the context where the probe is set. Adding the tag can also depend on condition
Motivation
Introduced new kind of probe to decorate existing span with dynamic tags
Additional Notes
Instrumentation will be implemented in next PR