Skip to content

fix: grizzly client reverse muzzle check#11258

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
ygree/fix-grizzly-client-muzzle-check
May 2, 2026
Merged

fix: grizzly client reverse muzzle check#11258
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
ygree/fix-grizzly-client-muzzle-check

Conversation

@ygree
Copy link
Copy Markdown
Contributor

@ygree ygree commented May 1, 2026

What Does This Do

Widen Grizzly client muzzle range because Grizzly 5 still exposes the com.ning AHC API and the old 1.16 cap causes a false inverse muzzle failure

Motivation

Broken CI

Additional Notes

:dd-java-agent:instrumentation:grizzly:grizzly-client-1.9:muzzle-AssertFail-org.glassfish.grizzly-grizzly-http-client-5.0.0 FAILED

Ref: #11256

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

… com.ning AHC API and the old 1.16 cap causes a false inverse muzzle failure
@ygree ygree self-assigned this May 1, 2026
@ygree ygree added the type: bug Bug report and fix label May 1, 2026
@ygree ygree marked this pull request as ready for review May 1, 2026 20:24
@ygree ygree requested a review from a team as a code owner May 1, 2026 20:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Comment thread dd-java-agent/instrumentation/grizzly/grizzly-client-1.9/build.gradle Outdated
@mcculls mcculls added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes labels May 1, 2026
Copy link
Copy Markdown
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to get master unblocked - using a range of "[1.9,1.16],[5,6)" should also work and is more accurate

@mcculls mcculls enabled auto-merge May 1, 2026 23:25
@mcculls mcculls added this pull request to the merge queue May 2, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 2, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 2, 2026

View all feedbacks in Devflow UI.

2026-05-02 00:14:06 UTC ℹ️ Start processing command /merge


2026-05-02 00:14:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-02 01:42:30 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 2, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit becc7de into master May 2, 2026
569 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the ygree/fix-grizzly-client-muzzle-check branch May 2, 2026 01:42
@github-actions github-actions Bot added this to the 1.62.0 milestone May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants