Add connect event tree node support in activity tree#53019
Conversation
Connect events were listed in the V2 event types but had no case in insertEvent, silently falling through to the default no-op path. Add ConnectNode (mirroring BindNode), InsertConnectEvent on SocketNode and ProcessNode, and wire the ConnectEventType case in insertEvent. Proto serialization support requires an agent-payload update and is left as a follow-up. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d8fbb03f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Family string | ||
| GenerationType NodeGenerationType | ||
| Bind []*BindNode | ||
| Connect []*ConnectNode |
There was a problem hiding this comment.
Serialize connect endpoints before storing them
Because V2 profiles enable connect by default, nodes appended to this new Connect slice are now learned in memory, but profile persistence still goes through activity_tree.ToProto: socketNodeToProto only initializes and emits Bind entries, and protoDecodeProtoSocket only reads GetBind(). In any local/remote persistence or restart path, learned connect endpoints are therefore dropped, so a profile that learned outbound connections will reload/upload as sockets with no connect activity and will keep reporting the same connects as new.
Useful? React with 👍 / 👎.
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7d8fbb0 | Docs | Datadog PR Page | Give us feedback! |
Files inventory check summaryFile checks results against ancestor cfc647c1: Results for datadog-agent_7.82.0~devel.git.484.7d8fbb0.pipeline.121974823-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
19 successful checks with minimal change (< 2 KiB)
|
Connect events were listed in the V2 event types but had no case in insertEvent, silently falling through to the default no-op path. Add ConnectNode (mirroring BindNode), InsertConnectEvent on SocketNode and ProcessNode, and wire the ConnectEventType case in insertEvent.
Proto serialization support requires an agent-payload update and is left as a follow-up.
What does this PR do?
Motivation
Describe how you validated your changes
Additional Notes