Remove atomics section from codereview_guideline.md#53018
Remove atomics section from codereview_guideline.md#53018rahulkaukuntla wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02e5c10854
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| to guarantee alignment, unless placed as the first field with a comment | ||
| explaining why a pointer was not used. | ||
|
|
||
| ### Testing: `require` vs `assert` |
There was a problem hiding this comment.
Keep coverage for primitive atomic APIs
This deletion removes the reviewer-facing warning about sync/atomic, but the Go 1.19 alignment fix only covers the new typed values; primitive 64-bit functions such as atomic.AddUint64 still require caller-arranged alignment on ARM/386/32-bit MIPS, and the public Go guideline still tells contributors to use go.uber.org/atomic instead (docs/public/guidelines/languages/go.md:122-130). With this gone, a PR adding primitive sync/atomic on a struct field can pass review while remaining broken on supported 32-bit/ARM targets, so please replace this with a narrower rule for primitive APIs rather than removing it outright.
Useful? React with 👍 / 👎.
Files inventory check summaryFile checks results against ancestor cf57354d: Results for datadog-agent_7.82.0~devel.git.498.02e5c10.pipeline.121972054-1_amd64.deb:No change detected |
What does this PR do?
Due to golang/go#50860, with the adoption of go version 1.19:
This repo is already >1.19, so we don't need to move over to the uber atomic library.
Motivation
Describe how you validated your changes
Additional Notes