Skip to content
This repository was archived by the owner on Aug 10, 2023. It is now read-only.

Fix broken footer, content covered by navbar #37

Merged
ekowidianto merged 3 commits into from
Jun 28, 2023
Merged

Fix broken footer, content covered by navbar #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6ce36e
fix(footer): global `footer` selector breaks other `footer` elements
pchunky Jun 28, 2023
bd5538a
fix(layouts): 50px top of content covered by navbar
pchunky Jun 28, 2023
30d56c1
fix(footer): covers portion of the content
pchunky Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions assets/stylesheets/coursemology.org/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@
box-shadow: 0 $v-shadow $blur $spread $gray-light;
}

.root.container-fluid.footer-buffer {
padding-top: $navbar-height + $navbar-margin-bottom;
body {
position: relative;
}

.footer-buffer {
padding-top: 5rem;

@media screen and (max-width: 937px) {
padding-bottom: 120px;
}
Expand All @@ -31,7 +33,7 @@
}
}

footer {
.static-footer {
border-top: 1px solid $gray-lighter;
bottom: 0;
color: $gray-light;
Expand Down
2 changes: 1 addition & 1 deletion views/layouts/coursemology.org.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ html
div class=@page_class
= yield

footer
footer.static-footer
div.container-fluid
div.row
div.col-md-7.col-lg-7.footer-links
Expand Down