Skip to content

Add ko localization, sync docs.json, and update node docs#1109

Merged
comfyui-wiki merged 26 commits into
Comfy-Org:mainfrom
OneVth:ko-i18n
Jun 8, 2026
Merged

Add ko localization, sync docs.json, and update node docs#1109
comfyui-wiki merged 26 commits into
Comfy-Org:mainfrom
OneVth:ko-i18n

Conversation

@OneVth

@OneVth OneVth commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds full Korean (ko) localization of the ComfyUI documentation: 1,126 pages plus 42 snippet files. Translations were produced from the English source using qwen-mt-turbo with a deterministic post-processing pass.

What's included

Content

  • ko/ — 1,126 translated pages
  • snippets/ko/ — 42 translated snippets

Infrastructure

  • docs.json — Korean language group added to navigation.languages (en / zh / ja / ko)
  • .github/scripts/check-ko.ts — Korean translation quality checker (Hangul ratio + leaked-English detection), mirroring check-ja.ts
  • .github/workflows/ko-sync-check.yml — PR-time sync check, mirroring the existing ja-sync-check.yml / zh-cn-sync-check.yml
  • .github/scripts/translation-config.jsonko registered in the languages list
  • .github/workflows/translation-sync.ymlko/ and snippets/ko/ added to the git-add step so the automated sync commits Korean changes
  • giscus-comments.js — Korean branch for the comment widget notices

Auto-sync enrollment

Korean is wired into both existing translation mechanisms:

  • PR-time checkko-sync-check.yml warns when an English page changes without a matching Korean update, the same way ja-sync-check.yml and zh-cn-sync-check.yml already do.
  • Post-merge sync — registering ko in translation-config.json and adding ko/ / snippets/ko/ to the git-add step in translation-sync.yml enrolls Korean in the automated translate-sync pipeline, so it stays in sync as English docs evolve.

If you'd prefer to land the content first and review the auto-sync enrollment separately, the translation-config.json and translation-sync.yml changes are isolated to two commits and can be split out.

Test plan

  • docs.json is valid JSON; every Korean page path maps 1:1 to a file on disk (no missing pages)
  • mint dev — 0 parse errors across ko/ and snippets/ko/
  • Language switcher shows Korean; ko/ pages render, including the JSX-heavy ko/index.mdx
  • mint broken-links — 0 broken links (Korean internal links resolve with the /ko/ prefix)
  • check-ko.ts — 0 failures
  • giscus comment notices display in Korean on /ko/ pages

OneVth and others added 25 commits June 7, 2026 01:48
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
번역 후처리에서 누락된 description frontmatter 따옴표를 복원합니다.
ko/ 및 snippets/ko/ 전체 MDX 파일 697건을 일괄 수선.
특히 ko/custom-nodes/js/subgraphs.mdx는 ': ' 포함으로 YAML 파싱 실패 상태였음.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
07a 빌드 검증에서 발견된 21건의 파싱 에러를 EN 원본 대조 기반으로 복원.
번역 내용은 그대로 유지하고 구조만 복원.

타입1: 닫힘 태그 누락 6건 (</Note>, </Warning>)
- ko/account/delete-account.mdx
- ko/custom-nodes/workflow_templates.mdx
- ko/installation/system_requirements.mdx
- ko/support/payment/accepted-payment-methods.mdx
- ko/tutorials/basic/upscale.mdx
- snippets/ko/install/desktop-resource-warning.mdx

타입2: JSX 내부 닫힘 태그 누락 7건
- ko/agent-tools/index.mdx (</Card>)
- ko/cloud/import-models.mdx (</Accordion>)
- ko/development/core-concepts/models.mdx (</Accordion>)
- ko/get_started/cloud.mdx (</Card>)
- ko/interface/settings/comfy.mdx (</Tab>)
- ko/interface/settings/overview.mdx (</Card>)
- snippets/ko/install/desktop-venv.mdx (</Tab>)

타입3: &lt; 엔티티 → 리터럴 < 복원 17건 (4파일)
- ko/built-in-nodes/AdjustBrightness.mdx
- ko/built-in-nodes/AdjustContrast.mdx
- ko/built-in-nodes/ElevenLabsTextToSpeech.mdx
- ko/tutorials/partner-nodes/pricing.mdx

타입4: 플레이스홀더 백틱 감싸기 2건
- ko/manager/configuration.mdx
- ko/development/core-concepts/custom-nodes.mdx

타입5: <Update> 미닫힘 + 속성명 오류 3건
- ko/changelog/index.mdx

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolves modify/delete conflict by keeping main's removal of translation-sync.yml.
…ing.

Drop check-ko.ts and ko-sync-check.yml; Korean is covered by check-i18n-sync.mjs and translate-i18n.ts via translation-config.json.
built-in-nodes is maintained by embedded-docs and skipped by the i18n pipeline; point ko nav and internal links to English built-in-nodes pages instead.
Add hashes for 44 ko files that had translations but no metadata; leave 63 stale hashes unchanged so batch translate still picks up EN updates.
Restore missing closing brace and fence lost during initial Korean translation.
…n path rules.

Move translation scripts into a dedicated folder, add truncation scan/repair and shared i18n-config, fix language path handling for new locales, and reorganize contributing READMEs into readme/.
…ions.

Fix chunked path localization and checkpoint each translated <Update> block to disk so ja/zh/ko changelog runs can resume without losing progress.
…ation.

Add sync-docs-json and nav-label-translate modules, centralize translate log paths, and run nav sync at end of translate.
Sync page paths and translated group/tab titles with the English navigation structure.
Batch translation sync for Korean content, ja/zh built-in node pages, and related locale updates.
Gitignore the new log directory and document .txt/json log filenames in EN and locale readmes.
Default npm run translate now processes pages then snippets in one run; add --pages-only to skip snippets and keep --snippets for snippets-only.
…eference.

Skip API calls for already-localized tab/group titles and include the existing map in batch prompts for consistent new labels.
Repair truncated startup-flags and ernie-image accordions, clean ja shortcuts frontmatter, and add ko desktop migrate/update snippets plus ja/zh generate snippet translations.
Normalize docs.json paths via i18n sync (case-correct EN entries, prune missing ko nav), raise Mintlify dev heap and skip OpenAPI locally, and fix ko/snippet Step nesting plus giscus ja/ko exclusions.
Exclude dependency and local tooling paths so pnpm dev no longer floods the terminal with MDX parsing errors from package changelogs.
@comfyui-wiki

comfyui-wiki commented Jun 8, 2026

Copy link
Copy Markdown
Member

Thank you, @OneVth

@comfyui-wiki comfyui-wiki changed the title Add Korean (ko) localization Add ko localization, sync docs.json, and update node docs Jun 8, 2026
Add missing ko/built-in-nodes/overview page and nav entry, and exclude readme/ from Mintlify link checks since those files are GitHub-only.
@comfyui-wiki comfyui-wiki merged commit 1b460cf into Comfy-Org:main Jun 8, 2026
6 checks passed
@OneVth

OneVth commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for adapting it to the new i18n tooling and merging it in! Glad the Korean docs are live now. Happy to help keep them polished going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants