-
Notifications
You must be signed in to change notification settings - Fork 186
Update settings documentation to match frontend code #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lin-bot23
wants to merge
9
commits into
Comfy-Org:main
Choose a base branch
from
lin-bot23:update/settings-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
68bc5b9
Update settings documentation to match frontend code
lin-bot23 02cea66
Update zh/ja settings docs to match frontend code
lin-bot23 9fc20d7
Fix supported languages list: add missing locale options
lin-bot23 6fc4d70
fix: apply audit fixes to settings docs (3d, about, extension, server…
lin-bot23 92bb715
fix: update overview.mdx and comfy-desktop.mdx to match frontend
lin-bot23 0aa5fbc
fix: escape bare URL in about.mdx to fix mint parse error
lin-bot23 69ab72f
Merge remote-tracking branch 'origin/main' into update/settings-docs …
lin-bot23 b1a9cd5
sync EN settings docs changes to ZH/JA (overview + about)
lin-bot23 c69fcee
fix: use MDX comment syntax instead of HTML comment in extension.mdx
lin-bot23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: Comfy-Org/docs
Length of output: 156
🏁 Script executed:
Repository: Comfy-Org/docs
Length of output: 33758
🌐 Web query:
ComfyUI frontend installed_templates_version required_templates_version Templates danger severity💡 Result:
In ComfyUI, installed_templates_version and required_templates_version are system parameters used to manage the compatibility between the core ComfyUI application and the installed workflow templates package [1][2][3]. These fields are exposed via the /system_stats endpoint [2][3]. Their primary purpose is to allow the frontend to detect version mismatches [4]. When the installed version of the workflow templates does not meet the requirements defined in ComfyUI's requirements.txt, the system may trigger warnings or toast notifications to alert the user [2][4]. Regarding "danger" or "severity" levels: ComfyUI does not typically categorize these version mismatches with explicit "danger" or "severity" metadata levels (such as high, medium, or low) in its core code [1][3]. Instead, the system handles these as compatibility checks [4]: 1. Version Mismatch: If a mismatch is detected, the system generates logs and warnings [4]. Users often experience this as "missing node" errors, 404 errors when loading templates, or simply the disappearance of certain template options from the UI [5][6][7][8]. 2. Resolution: These issues are generally resolved by updating the comfyui-workflow-templates package in the user's Python environment (e.g., using pip install --upgrade comfyui-workflow-templates) or by ensuring both ComfyUI and the manager are up to date [8][9]. While there is no formal severity scale, a version mismatch is functionally critical for specific features; if the templates are outdated, the associated workflows or nodes will often fail to execute or load, rendering those specific features non-functional [5][6][8].
Citations:
Keep the Templates danger wording consistent across locales. The badge text uses a version mismatch, but the system-info summary says only “outdated.” Keep the English, Japanese, and Chinese pages in lockstep so the docs don’t turn into a mismatch mishmash.
📍 Affects 3 files
interface/settings/about.mdx#L25-L29(this comment)interface/settings/about.mdx#L56-L56ja/interface/settings/about.mdx#L27-L31ja/interface/settings/about.mdx#L58-L58zh/interface/settings/about.mdx#L25-L29zh/interface/settings/about.mdx#L56-L56🤖 Prompt for AI Agents