Skip to content

Several fixes and new features for the request progress bar#280

Open
Nate-Wessel wants to merge 6 commits into
deployfrom
progress-bar-fixes
Open

Several fixes and new features for the request progress bar#280
Nate-Wessel wants to merge 6 commits into
deployfrom
progress-bar-fixes

Conversation

@Nate-Wessel

@Nate-Wessel Nate-Wessel commented Jul 17, 2026

Copy link
Copy Markdown
Member

Will resolve #227.

This refines the progress bar, solving the bugs in #227 and providing some addition information to the user:

  • how many requests are active with the server (<=3)
  • how many requests are just waiting

These are given in the text description and in the progress bar visual.

@Nate-Wessel Nate-Wessel self-assigned this Jul 17, 2026
@Nate-Wessel Nate-Wessel added bug front-end new feature javascript Pull requests that update javascript code labels Jul 17, 2026
@Nate-Wessel

Copy link
Copy Markdown
Member Author

I'm kind of tempted to animate the fill of the in-flight portion of the progress bar...

@Nate-Wessel Nate-Wessel changed the title Several fixes and new fetures for the request progress bar Several fixes and new features for the request progress bar Jul 17, 2026
@Nate-Wessel

Copy link
Copy Markdown
Member Author

I think this can probably be finished by just connecting the appearance of the download buttons to the actual data.queue event indicating that the queue is empty. The way it's calculated now it think it's down once all requests have been sent (but not necessarily resolved).

@Nate-Wessel
Nate-Wessel requested a review from rbahreh July 20, 2026 14:09
@Nate-Wessel
Nate-Wessel marked this pull request as ready for review July 20, 2026 16:21
@Nate-Wessel

Copy link
Copy Markdown
Member Author

Some useful documentation regarding the queue: https://github.com/sindresorhus/p-queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug front-end javascript Pull requests that update javascript code new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress bar appears to show number requested, not number completed?

1 participant