Fix flaky error-result timeout test - #9980
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a flaky execution test in HotChocolate.Execution.Tests to avoid racey, wall-clock cancellation that can surface as a spurious “request execution was canceled” error on slow/contended CI.
Changes:
- Replaces the in-test
CancellationTokenSource(1000)deadline with an xUnit[Fact(Timeout = 30_000)]timeout guard. - Passes
TestContext.Current.CancellationTokenintoExecuteRequestAsyncso cancellation is owned by the test framework rather than an arbitrary 1s timer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
This was referenced Jun 26, 2026
This was referenced Jul 5, 2026
This was referenced Jul 13, 2026
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Aug 1, 2026
This was referenced Aug 10, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestExecutorTests.Ensure_Errors_Do_Not_Result_In_Timeoutsbounded its execution withnew CancellationTokenSource(1000), a wall-clock deadline. On a slow or contended CI runner the 1s timer could fire mid-execution and fold a cancellation error into the result, flipping the snapshot from"Unexpected Execution Error"to"The GraphQL request execution was canceled."and failing the test even though nothing hung.[Fact(Timeout = 30_000)]guard and passedTestContext.Current.CancellationToken, so the test still fails fast on a genuine hang without racing normal-load execution time.Test plan
dotnet testonHotChocolate.Execution.Tests, filtered toEnsure_Errors_Do_Not_Result_In_Timeouts— passes.