Fix #6177 custom ID filter input override - #9232
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes HotChocolate filtering behavior for [ID]-annotated fields so that explicitly configured custom IdOperationFilterInputType derivatives are not overwritten during type discovery, and adds a regression test for #6177.
Changes:
- Added a regression test ensuring an explicitly configured custom ID operation filter input type is used for an
[ID]field. - Updated
FilterTypeInterceptor.ApplyIdAttributesToFieldsto keep explicitly configured custom ID operation filter input types instead of always forcingIdOperationFilterInputType.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/HotChocolate/Data/test/Data.Filters.Tests/Issue6177ReproTests.cs |
Adds regression coverage for custom ID operation filter input types on [ID] fields. |
src/HotChocolate/Data/src/Data/Filters/Convention/FilterTypeInterceptor.cs |
Adjusts ID attribute handling to respect explicitly configured custom ID filter input types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Remove accidental self-referential graphql-platform submodule - Add comment explaining SyntaxTypeReference limitation in ApplyIdAttributesToFields (SDL-only, no runtime type info) - Convert Issue6177ReproTests to CookieCrumble snapshot style with .MatchSnapshot() and generated .graphql snapshot files
This was referenced Jul 13, 2026
This was referenced Jul 20, 2026
This was referenced Jul 26, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Aug 3, 2026
This was referenced Aug 11, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6177