Skip to content

Fix snapshot filename casing to match test method names - #10171

Merged
glen-84 merged 1 commit into
mainfrom
gai/fix-snapshot-filename-casing
Jul 31, 2026
Merged

Fix snapshot filename casing to match test method names#10171
glen-84 merged 1 commit into
mainfrom
gai/fix-snapshot-filename-casing

Conversation

@glen-84

@glen-84 glen-84 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Three snapshot files were stored under names whose casing did not match their test methods: sharedMaxAgeAndInheritMaxAgeOnSameField, Var_is_object_with_field_a_set_to_abc_Valid, and Var_is_object_with_field_b_set_to_123_Valid. On a case-sensitive filesystem CookieCrumble does not resolve them, so it writes a second snapshot alongside the existing one instead of comparing against it.
  • Renamed each file to the exact test method name. File contents are untouched (pure renames, 100% similarity).

Test plan

  • Full test suite on Linux with a case-sensitive checkout: HotChocolate.Types.Tests (3509 tests) and HotChocolate.Caching.Tests (72 tests) pass on every target framework, and no snapshot files are regenerated.
  • Scanned every snapshot filename segment against the identifiers declared in its test project; no further mismatches across 5971 snapshot files.

Copilot AI review requested due to automatic review settings July 31, 2026 10:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84
glen-84 merged commit 8e26369 into main Jul 31, 2026
150 checks passed
@glen-84
glen-84 deleted the gai/fix-snapshot-filename-casing branch July 31, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants