Skip to content

Fix Parent requirements for colliding resolver fields - #10164

Merged
tobias-tengler merged 2 commits into
mainfrom
tte/fix-parent-requires-projection-collision
Jul 29, 2026
Merged

Fix Parent requirements for colliding resolver fields#10164
tobias-tengler merged 2 commits into
mainfrom
tte/fix-parent-requires-projection-collision

Conversation

@tobias-tengler

Copy link
Copy Markdown
Member

Fixes #10163

Copilot AI review requested due to automatic review settings July 29, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Patch coverage

94.1% of changed lines covered (16/17)

File Covered Changed Patch %
…/Optimizers/QueryableRequirementsProjectionOptimizer.cs 1 2 50.0% 🔴
…/Core/src/Types/Execution/Processing/OperationCompiler.cs 4 4 100.0% 🟢
…/Core/src/Types/Execution/Processing/Selection.cs 6 6 100.0% 🟢
…/Expressions/Handlers/QueryableProjectionHandlerBase.cs 3 3 100.0% 🟢
…/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs 1 1 100.0% 🟢
…/Projections/Optimizers/IsProjectedProjectionOptimizer.cs 1 1 100.0% 🟢
Uncovered changed lines (JSON)
{
  "sha": "ccac67a5244e3bfc61c5dc79cf56074f4d8a6c51",
  "files": [
    { "path": "src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs", "ranges": [[97, 97]] }
  ]
}

Project coverage: 53.9% (232922/432145 lines)

@tobias-tengler
tobias-tengler marked this pull request as draft July 29, 2026 09:37
@tobias-tengler
tobias-tengler marked this pull request as ready for review July 29, 2026 10:20
@michaelstaib
michaelstaib self-requested a review July 29, 2026 11:01

@michaelstaib michaelstaib left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobias-tengler
tobias-tengler merged commit 327fbba into main Jul 29, 2026
147 checks passed
@tobias-tengler
tobias-tengler deleted the tte/fix-parent-requires-projection-collision branch July 29, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Parent(requires:)] is silently ignored under [UseProjection] when another resolver field is named after the required property

3 participants