Hoist source path segment transcoding out of Fusion batch merges - #10153
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes Fusion’s batch result merging by hoisting source-path field-name transcoding out of the per-result merge loop, so the source path is encoded once and reused across all results in a batch.
Changes:
- Precompute UTF-8 encoded field-segment names (and segment end offsets) once per
AddPartialResults*call and reuse them when extracting data elements. - Add a
GetDataElementoverload that consumes the pre-encoded segment names to avoid repeated per-result transcoding. - Add a regression test that covers merging when the source path contains multiple field segments (with/without errors).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Results/FetchResultStore.cs | Hoists path transcoding for batch merges and adds a span-based GetDataElement overload plus helpers. |
| src/HotChocolate/Fusion/test/Fusion.Execution.Tests/Execution/Results/FetchResultStoreTests.cs | Adds test coverage for multi-segment sourcePath batch merging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Aug 9, 2026
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.