Materialize Fusion result objects from selection-set row templates - #10139
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes Fusion JSON result materialization by introducing an operation-shared, selection-set-level “object row template” and a new MetaDb bulk-append path that copies/stamps prebuilt object blocks (including correct per-request exclusion stamping) instead of appending rows one-by-one.
Changes:
- Add
ObjectTemplatebuilt duringSelectionSet.Seal()and reuse it when creating object instances. - Add
MetaDb.AppendObjectBlock(...)with fast-path (single chunk) and spanning-path (multi-chunk) implementations, stamping parent pointers and per-request exclusion. - Add targeted regression/geometry tests for chunk-boundary behavior and “template leakage” across include/defer permutations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/HotChocolate/Fusion/test/Fusion.Execution.Tests/Text/Json/CompositeResultDocumentTests.cs | Adds regression tests covering chunk-splits, shared-template correctness, and include/defer leakage scenarios. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.MetaDb.cs | Adds AppendObjectBlock and spanning implementation to copy/stamp object blocks efficiently across chunks. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultDocument.cs | Switches object materialization to template-based block append; computes per-request excluded property-row offsets. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/SelectionSet.cs | Builds and stores the per-selection-set ObjectTemplate during seal. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Selection.cs | Exposes CanBeDeferred used to decide whether exclusion is request-dependent for a selection. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/ObjectTemplate.cs | New type that precomputes canonical object row blocks and tracks conditional/deferrable selection indices. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+438
to
+440
| var conditionalSelections = template.ConditionalSelections; | ||
| Span<int> excludedRowOffsets = stackalloc int[conditionalSelections.Length]; | ||
| var excludedCount = 0; |
| ref MemoryMarshal.GetReference(template), | ||
| (uint)template.Length); | ||
|
|
||
| // The trailing EndObject row keeps its template parent of zero. |
Contributor
Patch coverage100.0% of changed lines covered (205/205)
Project coverage: 53.8% (231652/430539 lines) |
This was referenced Aug 9, 2026
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.