Fix indentation - #10001
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies whitespace/formatting-only changes across multiple projects (HotChocolate, StrawberryShake, Nitro, Mocha), primarily adjusting indentation and line wrapping in C# code and embedded raw-string GraphQL/SQL/test snapshots to improve consistency and readability.
Changes:
- Reflowed various wrapped constructs (e.g.,
foreachheaders, argument lists, and hash-code expressions) to cleaner single-line or properly aligned multi-line formatting. - Normalized indentation inside embedded raw string literals (GraphQL SDL/queries, SQL, and test snapshot strings).
- Simplified redundant raw-string interpolation usages in Nitro Fusion publish-related tests by snapshotting the
expectedErrorMessagedirectly.
Reviewed changes
Copilot reviewed 17 out of 80 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.Tests/Analyzers/FragmentHelperTests.cs | Collapse wrapped foreach headers in tests. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/SchemaGeneratorTests.cs | Adjust indentation in embedded GraphQL strings. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/ScalarGeneratorTests.cs | Adjust indentation in embedded GraphQL strings. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/EntityIdRewriter.cs | Collapse wrapped foreach header. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/ResultFromEntityMapper.cs | Align indentation in wrapped LINQ foreach. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Descriptors/DataTypeDescriptor.cs | Reflow foreach formatting in constructor logic. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/Models/OperationModel.cs | Align indentation for multi-line TryGetValue call. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FragmentHelper.cs | Reflow foreach/LINQ formatting inside analyzer logic. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/DocumentAnalyzer.CollectOutputTypes.cs | Collapse wrapped foreach header. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/TypeMapperGenerator_EntityHandler.cs | Collapse wrapped foreach header. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/OperationServiceGenerator.cs | Fix parameter indentation alignment. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/JsonResultBuilderGenerator_BuildData.cs | Collapse wrapped foreach header. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Generators/DependencyInjectionGenerator.cs | Collapse wrapped foreach headers. |
| src/StrawberryShake/Client/src/Transport.WebSockets/Protocols/GraphQLWebSocket/GraphQLWebSocketMessageParser.cs | Remove awkward line break in if (...) condition. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/GlobalOptionsCommandTests.cs | Adjust snapshot indentation for CLI validation error output. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionPublishCommandTests.cs | Simplify snapshot usage and normalize snapshot indentation. |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishValidateCommandTests.cs | Snapshot expectedErrorMessage directly (remove redundant raw-string wrapper). |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishCommitCommandTests.cs | Snapshot expectedErrorMessage directly (remove redundant raw-string wrapper). |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishCancelCommandTests.cs | Snapshot expectedErrorMessage directly (remove redundant raw-string wrapper). |
| src/Nitro/CommandLine/test/CommandLine.Tests/Commands/Fusion/FusionConfigurationPublishBeginCommandTests.cs | Snapshot expectedErrorMessage directly (remove redundant raw-string wrapper). |
| src/Mocha/src/Mocha.Transport.Postgres/Topology/PostgresSubscription.cs | Normalize indentation in interpolated SQL raw string. |
| src/Mocha/src/Mocha.Transport.Postgres/Tasks/QueueMonitoringTask.cs | Normalize indentation in interpolated SQL raw string. |
| src/Mocha/src/Mocha.EntityFrameworkCore.Postgres/Outbox/PostgresMessageOutboxQueries.cs | Fix indentation alignment in SQL update statement. |
| src/HotChocolate/Raven/test/Data.Raven.Sorting.Tests/QueryableSortVisitorObjectTests.cs | Adjust indentation in embedded GraphQL query strings. |
| src/HotChocolate/Mutable/src/Types.Mutable/Extensions/DirectiveLocationExtensions.cs | Re-indent dictionary initializer for consistency. |
| src/HotChocolate/MongoDb/test/Data.MongoDb.Paging.Tests/MongoDbRelayTests.cs | Adjust indentation in embedded GraphQL query strings. |
| src/HotChocolate/MongoDb/src/Data/Filters/Convention/Extensions/MongoDbFilterConventionDescriptorExtensions.cs | Re-indent fluent binding chain. |
| src/HotChocolate/Language/test/Language.Tests/Visitors/SyntaxRewriterTests.cs | Adjust indentation in embedded SDL string. |
| src/HotChocolate/Language/test/Language.Tests/Parser/Utf8HelperTests.cs | Fix indentation alignment of method parameters. |
| src/HotChocolate/Language/test/Language.SyntaxTree.Tests/EnumTypeExtensionNodeTests.cs | Re-align constructor argument indentation in tests. |
| src/HotChocolate/Language/test/Language.SyntaxTree.Tests/EnumTypeDefinitionNodeTests.cs | Re-align constructor argument indentation in tests. |
| src/HotChocolate/Language/src/Language.Web/Sha256DocumentHashProvider.cs | Fix constructor initializer indentation. |
| src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker~1.Leave.cs | Re-align method parameter indentation. |
| src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker~1.Enter.cs | Re-align method parameter indentation. |
| src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker.Leave.cs | Re-align method parameter indentation. |
| src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker.Enter.cs | Re-align method parameter indentation. |
| src/HotChocolate/Language/src/Language.SyntaxTree/NameNode.cs | Collapse GetHashCode expression to one line. |
| src/HotChocolate/Fusion/test/Fusion.Utilities.Tests/Rewriters/InlineFragmentOperationRewriterTests.cs | Adjust indentation in embedded GraphQL query strings. |
| src/HotChocolate/Fusion/test/Fusion.Utilities.Tests/Rewriters/DocumentRewriterTests.cs | Adjust indentation in embedded GraphQL query strings. |
| src/HotChocolate/Fusion/test/Fusion.Execution.Tests/Planning/FusionBenchmarkTests.cs | Normalize indentation in large embedded GraphQL query. |
| src/HotChocolate/Fusion/test/Fusion.Composition.Tests/PostMergeValidationRules/RequireInvalidFieldsRuleTests.cs | Adjust indentation in embedded SDL string. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/RequireTests.cs | Adjust indentation in embedded GraphQL query string. |
| src/HotChocolate/Fusion/test/Fusion.AspNetCore.Tests/GlobalObjectIdentificationTests.cs | Fix indentation of raw string argument. |
| src/HotChocolate/Fusion/src/Fusion.Execution.Types/Directives/LookupDirective.cs | Normalize indentation of SDL comment block. |
| src/HotChocolate/Fusion/src/Fusion.Execution.Types/Directives/ImplementsDirectiveParser.cs | Normalize indentation of SDL comment block. |
| src/HotChocolate/Fusion/benchmarks/Fusion.Execution.Benchmarks/FusionBenchmarkBase.cs | Normalize indentation in large embedded GraphQL query. |
| src/HotChocolate/Data/test/Data.Tests/IntegrationTests.cs | Adjust indentation in embedded GraphQL fragment strings. |
| src/HotChocolate/Data/test/Data.Sorting.SqlLite.Tests/QueryableSortVisitorObjectTests.cs | Adjust indentation in embedded GraphQL query strings. |
| src/HotChocolate/Data/test/Data.Sorting.SqlLite.Tests/QueryableSortVisitorExpressionTests.cs | Fix indentation in array initializer. |
| src/HotChocolate/Data/test/Data.Sorting.InMemory.Tests/QueryableSortVisitorExpressionTests.cs | Fix indentation in array/object initializers. |
| src/HotChocolate/Data/test/Data.Filters.Tests/Expression/FilterVisitorTestBase.cs | Fix indentation in lambda expression formatting. |
| src/HotChocolate/Core/test/Validation.Tests/DocumentValidatorTests.cs | Adjust indentation in embedded GraphQL document. |
| src/HotChocolate/Core/test/Types.Tests/Types/Validation/DirectiveValidationRuleTests.cs | Normalize indentation in embedded SDL strings. |
| src/HotChocolate/Core/test/Types.Tests/Types/DirectiveTypeTests.cs | Normalize indentation in embedded SDL string. |
| src/HotChocolate/Core/test/Types.Tests/SchemaFirstTests.cs | Normalize indentation in embedded SDL string. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/ObjectTypeTests.XmlDocInference.Ported.cs | Normalize indentation in embedded source snapshot string. |
| src/HotChocolate/Core/test/Types.Analyzers.Tests/ObjectTypeTests.XmlDocInference.cs | Normalize indentation in embedded source snapshot strings. |
| src/HotChocolate/Core/test/Execution.Tests/SchemaFirstTests.cs | Normalize indentation in embedded SDL string. |
| src/HotChocolate/Core/test/Execution.Tests/Processing/OperationCompilerTests.cs | Normalize indentation of closing delimiters in raw strings. |
| src/HotChocolate/Core/test/Execution.Tests/Integration/TypeConverter/TypeConverterTests.ExceptionPropagation.cs | Normalize indentation in theory data initialization. |
| src/HotChocolate/Core/src/Validation/TypeDocumentValidatorVisitor.cs | Re-align method parameter indentation. |
| src/HotChocolate/Core/src/Validation/Rules/VariableVisitor.cs | Re-align method parameter indentation. |
| src/HotChocolate/Core/src/Types/Utilities/ReflectionUtils.cs | Fix indentation alignment in throw expression formatting. |
| src/HotChocolate/Core/src/Types/Utilities/DefaultTypeConverter.Setup.cs | Fix indentation alignment of method parameter list. |
| src/HotChocolate/Core/src/Types/Types/Scalars/IntegerTypeBase.cs | Fix base-constructor indentation. |
| src/HotChocolate/Core/src/Types/Types/Scalars/FloatTypeBase.cs | Fix base-constructor indentation. |
| src/HotChocolate/Core/src/Types/Types/Helpers/DescriptorHelpers.cs | Fix indentation alignment of method parameters. |
| src/HotChocolate/Core/src/Types/Types/Descriptors/UnionTypeDescriptor.cs | Fix indentation alignment of null-coalescing throw. |
| src/HotChocolate/Core/src/Types/SchemaErrorBuilder.cs | Fix indentation alignment of method parameters. |
| src/HotChocolate/Core/src/Types/Internal/TypeExtensionHelper.cs | Fix indentation alignment of lambda argument formatting. |
| src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Types.cs | Fix indentation alignment of extension method signatures. |
| src/HotChocolate/Core/src/Types/Execution/Options/NodeIdSerializerOptions.cs | Fix indentation alignment in exception construction. |
| src/HotChocolate/Core/src/Types/Execution/DependencyInjection/SchemaRequestExecutorBuilderExtensions.Types.cs | Fix indentation alignment of extension method signatures. |
| src/HotChocolate/Core/src/Types/Configuration/ExtendedTypeRefEqualityComparer.cs | Collapse hash computation to one line. |
| src/HotChocolate/Core/src/Types.Mutations/MutationConventionTypeInterceptor.cs | Fix indentation alignment in Options construction. |
| src/HotChocolate/Caching/test/Caching.Tests/CacheControlTypeInterceptorTests.cs | Normalize indentation in embedded SDL string. |
| src/HotChocolate/AspNetCore/test/AspNetCore.Tests.Utilities/Subscriptions/Apollo/WebSocketExtensions.cs | Fix indentation alignment of method call arguments. |
| src/HotChocolate/AspNetCore/test/AspNetCore.Authorization.Tests/AuthorizationTests.cs | Fix indentation alignment of lambda argument. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Utilities/ThrowHelper.cs | Collapse method signature and align expression body formatting. |
| src/HotChocolate/AspNetCore/src/AspNetCore.Pipeline/Subscriptions/WebSocketConnection.cs | Fix indentation alignment of method parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Patch coverage88.9% of changed lines covered (176/198) +10 more changed files; see the JSON below for uncovered lines. Uncovered changed lines (JSON){
"sha": "ed2d039ecdc4b71cfb20a87c6ec3c93f07bfa885",
"files": [
{ "path": "src/HotChocolate/Core/src/Types/Execution/Options/NodeIdSerializerOptions.cs", "ranges": [[56, 56]] },
{ "path": "src/HotChocolate/Core/src/Types/Types/Descriptors/UnionTypeDescriptor.cs", "ranges": [[95, 95]] },
{ "path": "src/Mocha/src/Mocha.Transport.Postgres/Tasks/QueueMonitoringTask.cs", "ranges": [[26, 34]] },
{ "path": "src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker.Enter.cs", "ranges": [[282, 282], [287, 287]] },
{ "path": "src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker.Leave.cs", "ranges": [[283, 283], [288, 288]] },
{ "path": "src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker~1.Enter.cs", "ranges": [[284, 284], [289, 289]] },
{ "path": "src/HotChocolate/Language/src/Language.Visitors/SyntaxWalker~1.Leave.cs", "ranges": [[283, 283], [288, 288]] },
{ "path": "src/HotChocolate/Core/src/Types/Internal/TypeExtensionHelper.cs", "ranges": [[29, 31]] }
]
}Project coverage: 52.4% (216266/412352 lines) |
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
This was referenced Jul 26, 2026
chore(deps): Bump HotChocolate.Subscriptions.InMemory from 15.1.14 to 16.5.1
Kuestenlogik/Bowire#506
Merged
This was referenced Aug 3, 2026
This was referenced Aug 11, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foreachheaders, and hash-code expressions that now fit on one line, and correct parameter-alignment indentation in the larger visitor and benchmark files.$"""{expectedErrorMessage}"""raw-string interpolations to the bare variable in the Nitro Fusion publish command tests.