Skip to content

test: add retry option for segfault - #6161

Merged
nazarhussain merged 1 commit into
unstablefrom
nh/fix-unit-tests
Dec 6, 2023
Merged

test: add retry option for segfault#6161
nazarhussain merged 1 commit into
unstablefrom
nh/fix-unit-tests

Conversation

@nazarhussain

@nazarhussain nazarhussain commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

Motivation

Make the CI more stable.

Description

Make the CI server more stable and avoid re-running the tests manually on segfaults

Some references are:
vitejs/vite#9492
vitest-dev/vitest#1854
nodejs/node#43617

Steps to test or reproduce

Run all tests.

@nazarhussain
nazarhussain marked this pull request as ready for review December 6, 2023 12:04
@nazarhussain
nazarhussain requested a review from a team as a code owner December 6, 2023 12:04
@nazarhussain nazarhussain self-assigned this Dec 6, 2023

@nflaig nflaig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sufficient workaround for now, tests usually pass on second run.

@nazarhussain
nazarhussain merged commit 4b9647f into unstable Dec 6, 2023
@nazarhussain
nazarhussain deleted the nh/fix-unit-tests branch December 6, 2023 14:17
jeluard pushed a commit that referenced this pull request Dec 7, 2023
@wemeetagain

Copy link
Copy Markdown
Member

馃帀 This PR is included in v1.13.0 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants