fix: skip inaccessible images to avoid build failure - #1301
Merged
Conversation
btxcy
pushed a commit
to btxcy/hugo-theme-stack
that referenced
this pull request
Mar 9, 2026
* skip inaccessible images to avoid build failure * undo changes to $result and $local * fix: initialize $resource as a dictionary instead of an empty string * feat: add external image processing timeout configuration --------- Co-authored-by: Jimmy Cai <jimmy@cai.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the markdown, if an external image is referred like following:
and the remote image is inaccessible (remote image is broken, or just due to network issue) during the Hugo building process, the build will fail with following message:
This happens even when the remote itself is fine, but it's just not accessible or loading very slowly during running
hugo serverorhugo -Dto build the site.So I propose that, in
layouts/_partials/helper/image.html, show warning instead error for inaccessible remote images and so that the Hugo build can continue without broken.