Skip to content

chore(deps): pull dagron-core from crates.io - #628

Merged
pratyush618 merged 1 commit into
masterfrom
chore/dagron-core-crates-io
Aug 4, 2026
Merged

chore(deps): pull dagron-core from crates.io#628
pratyush618 merged 1 commit into
masterfrom
chore/dagron-core-crates-io

Conversation

@kartikeya-27

@kartikeya-27 kartikeya-27 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

dagron-core 0.1.1 was published to crates.io, so the workspace no longer has to
resolve it from a pinned git revision.

-dagron-core = { git = "https://github.com/ByteVeda/dagron.git", rev = "d1b61aa..." }
+dagron-core = "0.1.1"

The pin was 11 commits behind. Everything the upgrade brings is additive from
taskito's side:

  • DAG::add_node now returns a stable NodeRef (Arc<str> name plus a per-node
    creation epoch) instead of a snapshot NodeId. Both taskito call sites —
    taskito-python/src/py_workflow/mod.rs and taskito-java/src/workflows/mod.rs
    discard the return value, so neither needs to change. NodeId is still exported
    and is still what the enumeration methods return.
  • New DAG::resolve_ref / DAG::node_ref, and a DagronError::StaleNodeRef
    variant for a handle whose node was removed and re-added. Taskito never matches
    on DagronError, only formats it.
  • SerializableGraph is untouched, so stored dag_json in workflow_definitions
    deserializes unchanged. No migration.

NodeRef is not adopted here because it solves a problem taskito's builders do
not have: they are append-only (add nodes, add edges, to_json, drop), never
remove a node, and never hold a handle after construction. topology.rs and
common.rs walk SerializableGraph fields directly.

taskito-workflows stays publish = false, but the reason changed — crates.io no
longer sees a git dependency, and the remaining blocker is the taskito-core path
dependency, which carries no registry version because core itself is unpublished.
The manifest comment now says that.

Verification

  • cargo check --workspace --features workflows — clean
  • cargo test --workspace --features workflows — green
  • cargo clippy --workspace --all-targets --features workflows — zero warnings
  • pyo3-leakage tripwire still empty for taskito-core, taskito-workflows, taskito-mesh

Note for a follow-up

The constraint is "0.1.1", i.e. ^0.1.1. Cargo treats 0.1.0 -> 0.1.1 as
compatible, yet that bump changed add_node's return type, so a future 0.1.2
could break the build on cargo update. Cargo.lock is committed, so CI and dev
builds are pinned today. If we want back the guarantee the git revision gave, the
constraint should be =0.1.1.

Summary by CodeRabbit

  • Chores
    • Updated the workspace to use the released dagron-core 0.1.1 package.
    • Clarified publication requirements for the workflows package.

dagron-core 0.1.1 is published, so the pinned git revision can go. The
publish blocker for taskito-workflows is now the unversioned taskito-core
path dependency, not the git dependency the old comment named.
@github-actions github-actions Bot added the rust label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: efd82118-05ae-42b9-8716-35d649f0be59

📥 Commits

Reviewing files that changed from the base of the PR and between 9f7d307 and 852783e.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • crates/taskito-workflows/Cargo.toml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • ByteVeda/taskito (manual)

📝 Walkthrough

Walkthrough

The workspace now uses released dagron-core version 0.1.1. The workflow package publication note now references the taskito-core path dependency and coordinated registry publication.

Changes

Registry dependency alignment

Layer / File(s) Summary
Dependency and publication alignment
Cargo.toml, crates/taskito-workflows/Cargo.toml
The workspace uses dagron-core version 0.1.1. The publication note references taskito-core.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: pratyush618

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: switching dagron-core from a Git revision to crates.io.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pratyush618
pratyush618 merged commit 39eba91 into master Aug 4, 2026
36 checks passed
@pratyush618
pratyush618 deleted the chore/dagron-core-crates-io branch August 4, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants