chore(deps): pull dagron-core from crates.io - #628
Merged
Conversation
dagron-core 0.1.1 is published, so the pinned git revision can go. The publish blocker for taskito-workflows is now the unversioned taskito-core path dependency, not the git dependency the old comment named.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe workspace now uses released ChangesRegistry dependency alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pratyush618
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dagron-core 0.1.1was published to crates.io, so the workspace no longer has toresolve it from a pinned git revision.
The pin was 11 commits behind. Everything the upgrade brings is additive from
taskito's side:
DAG::add_nodenow returns a stableNodeRef(Arc<str>name plus a per-nodecreation epoch) instead of a snapshot
NodeId. Both taskito call sites —taskito-python/src/py_workflow/mod.rsandtaskito-java/src/workflows/mod.rs—discard the return value, so neither needs to change.
NodeIdis still exportedand is still what the enumeration methods return.
DAG::resolve_ref/DAG::node_ref, and aDagronError::StaleNodeRefvariant for a handle whose node was removed and re-added. Taskito never matches
on
DagronError, only formats it.SerializableGraphis untouched, so storeddag_jsoninworkflow_definitionsdeserializes unchanged. No migration.
NodeRefis not adopted here because it solves a problem taskito's builders donot have: they are append-only (add nodes, add edges,
to_json, drop), neverremove a node, and never hold a handle after construction.
topology.rsandcommon.rswalkSerializableGraphfields directly.taskito-workflowsstayspublish = false, but the reason changed — crates.io nolonger sees a git dependency, and the remaining blocker is the
taskito-corepathdependency, which carries no registry version because core itself is unpublished.
The manifest comment now says that.
Verification
cargo check --workspace --features workflows— cleancargo test --workspace --features workflows— greencargo clippy --workspace --all-targets --features workflows— zero warningstaskito-core,taskito-workflows,taskito-meshNote for a follow-up
The constraint is
"0.1.1", i.e.^0.1.1. Cargo treats0.1.0->0.1.1ascompatible, yet that bump changed
add_node's return type, so a future0.1.2could break the build on
cargo update.Cargo.lockis committed, so CI and devbuilds are pinned today. If we want back the guarantee the git revision gave, the
constraint should be
=0.1.1.Summary by CodeRabbit
dagron-core0.1.1 package.