fix: stop the stale-reap test racing the clock - #609
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe stale-job reaping test sets both jobs’ ChangesStale-job reaping test
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
kartikeya-27
force-pushed
the
fix/flaky-reap-stale-test
branch
from
August 2, 2026 13:13
2006dab to
b863729
Compare
kartikeya-27
approved these changes
Aug 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_reap_stale_jobs_only_returns_expiredfails intermittently on master — mostrecently in the push-dispatch step of the SQLite job on run 30745567038, with
left: 0, right: 1.The feature is a red herring. The test captures
t0before enqueuing, butmake_jobdefaultsscheduled_at: now_millis(). When a millisecond ticks overbetween the two,
scheduled_at > t0, the candidate scan'sscheduled_at <= nowmatches nothing, both dequeues claim nothing, and the reap finds no running job.
Pins both jobs'
scheduled_attot0, so every timestamp in the test derivesfrom one clock reading. Skewing it by 1 ms first reproduces the CI assertion
exactly; every other dequeue in the suite already cushions with
+1000or readsthe clock after the enqueue.
Summary by CodeRabbit