docs: attached-executor deployment guide - #603
Conversation
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe landing page now presents Taskito as Rust-powered with native Python, Node.js, and Java SDKs. Operations navigation now links to a new attached executors guide covering setup, security, reporting, limitations, compatibility, and deployment. ChangesDocumentation updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/app/components/landing/sections.tsx`:
- Around line 409-415: Update the Java InstallPill entry alongside the existing
Python and pnpm commands to use a copyable Maven or Gradle dependency snippet,
or a valid versioned Maven install command, instead of the bare
org.byteveda:taskito coordinate; keep it compatible with InstallPill’s
shell-command rendering and copying behavior.
In `@docs/content/docs/shared/guides/operations/executor.mdx`:
- Around line 91-102: Update the Security guidance for non-loopback
TASKITO_LISTEN endpoints to require mTLS or an explicitly trusted encrypted
network, and document the supported configuration. Remove or qualify any wording
that presents token-only TCP as a strict security default, while preserving
token authentication and the Unix-socket guidance.
- Around line 31-40: Update the “Running the scheduler” documentation to replace
the unsupported `taskito executor ...` command examples with the published
executor entry points exposed by the Python, Node, and Java SDKs:
`Executor(...)`, `start_executor(...)`, and `Cli.executor`. Keep the existing
scheduler environment configuration unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 60b54c4a-6fe2-48c8-a609-612f76775292
📒 Files selected for processing (7)
docs/app/components/landing/footer.tsxdocs/app/components/landing/sections.tsxdocs/app/lib/landing-content.tsdocs/content/docs/java/guides/operations/meta.jsondocs/content/docs/node/guides/operations/meta.jsondocs/content/docs/python/guides/operations/meta.jsondocs/content/docs/shared/guides/operations/executor.mdx
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
ByteVeda/taskito(manual)
kartikeya-27
changed the title
2 participants
Two independent docs changes.
The attached-executor deployment guide
docs/content/docs/shared/guides/operations/executor.mdx, fanned out to Python, Node and Java and added to each SDK's operations nav. Covers the topology, the server-side environment,taskito executorper SDK, the security defaults, what a task can and cannot do on an executor, capability negotiation, and the trade-offs.This is the operator-facing half of #589 — the SDK work landed in #599, #600 and #601.
One ordering note. The Java tab shows
JobContext.current(), which is added by #602 and is not on master yet. Everything else on the page is live today. Merge after #602 if you want the page accurate on landing; merge before and the Java tab documents an API that is one PR away.Landing-page SDK naming
The site still described itself as a queue for two SDKs, which stopped being true when Java shipped:
The CTA's install row also gained
org.byteveda:taskitoalongside the pip and pnpm pills, so the copy and the commands agree.The page's
<meta name="description">already named all three, so it is unchanged.Verification
pnpm typecheck,pnpm lint,pnpm check:parityandpnpm buildare clean. The executor guide renders under all three SDKs (build/client/{python,node,java}/guides/operations/executor/index.html), and the new landing copy and the third install pill were checked in the built HTML.Note for whoever runs this locally:
pnpm buildneedsNODE_OPTIONS=--max-old-space-size=8192or it OOMs on the default heap. Pre-existing, and what CI already sets.Refs #589.
Summary by CodeRabbit