fix(java): stop silently disabling every compile task - #598
Merged
pratyush618 merged 2 commits intoAug 1, 2026
Merged
Conversation
ErrorProneOptions has no isEnabled member, so `isEnabled = false` resolved against the JavaCompile receiver instead. Test compilation and the FFM overlay have never run.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughChangesError Prone configuration
Reserved settings prefix
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kartikeya-27
approved these changes
Aug 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorProneOptionsexposesenabled, notisEnabled— the latter was thename under gradle-errorprone-plugin 3.x. Since the type has no
isEnabledmember today, Kotlin resolved the assignment against the outer receiver, the
JavaCompiletask:So every
JavaCompilein the module was disabled.compileJavaescaped onlybecause the block below it set
isEnabled = true, re-enabling that one task.Everything else has been silently skipped:
Two consequences, both shipping today:
:testreportsNO-SOURCEbecause notest classes are produced. Same for
:spring:compileTestJava.compileJava22Javawas disabled too, so the multi-release jar shipped with noMETA-INF/versions/22overlay and JDK 22+ consumers silently stayed on JNI —the opposite of what
NativeTransport.createdocuments.Error Prone itself was unaffected:
compileJavastill ran NullAway, becauseisEnablednever reached Error Prone in either direction.Changes
enabled.set(...)in all three build scripts, with a comment naming the trap.Enabling the tests surfaces one pre-existing failure, fixed in its own commit:
InMemorySettings.reservedPrefixes()never gainedmiddleware:disabled:when#596 added it to the core list, which is exactly the drift
ReservedSettingPrefixesTestexists to catch.Verification
build/classes/java/java22/…/FfmTransport.classis produced again, and the jarcarries 6
META-INF/versions/22entries.Summary by CodeRabbit
Bug Fixes
Chores