Skip to content

Fix getting correct catalog - #2367

Merged
cja769 merged 1 commit into
develop-6.1.xfrom
QA-4110-fix-get-correct-catalog
Aug 10, 2020
Merged

Fix getting correct catalog#2367
cja769 merged 1 commit into
develop-6.1.xfrom
QA-4110-fix-get-correct-catalog

Conversation

@putrenkov

Copy link
Copy Markdown
Contributor

A Brief Overview
Fix getting correct catalog when standard site has multiple catalogs

Link to QA issue
BroadleafCommerce/QA#4110

@cja769

cja769 commented Jul 20, 2020

Copy link
Copy Markdown

I don't understand why it's named after static assets. What's the reasoning behind the naming? Also this concept of setting the catalog based on operating on a catalog discriminated entity probably should be done deeper in the admin flow. More specifically, this probably needs to be done closer to persistence in some way. This is just one of likely many entry points to creating a relationship.

@putrenkov

putrenkov commented Jul 21, 2020

Copy link
Copy Markdown
Contributor Author

@cja769 I pushed changes, but not sure where could put trigger for my handler

@cja769

cja769 commented Jul 28, 2020

Copy link
Copy Markdown

@oleksiimiroshnyk I tested these changes and it's hitting the extension manager and everything but the new piece in the BroadleafAdminRequestProcessor doesn't seem to be getting hit at all. I checked from the client side and I'm not seeing the parameter in the request.

@oleksiimiroshnyk

Copy link
Copy Markdown

@cja769 are you sure you have everything up to date, rebuild etc ?
I'm able to put breakpoint in BroadleafAdminRequestProcessor and stop there. Also UI/html has changes..

As a side effect, now all status, ribbon etc calls are sent with that parameter.

xxx

@oleksiimiroshnyk

Copy link
Copy Markdown

@cja769 found why you don't see it.
Sorry, forgot to add enterprise project fix

@cja769
cja769 force-pushed the QA-4110-fix-get-correct-catalog branch from a0ee4d2 to 8465052 Compare August 10, 2020 22:23
… be saved in the wrong catalog in certain situations when a standard site has multiple catalog
@cja769
cja769 force-pushed the QA-4110-fix-get-correct-catalog branch from 8465052 to 0b84e97 Compare August 10, 2020 22:25
@cja769
cja769 merged commit 47d1b2e into develop-6.1.x Aug 10, 2020
@cja769
cja769 deleted the QA-4110-fix-get-correct-catalog branch August 10, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants