[BUMP:cli:0.4.0-canary.1] [BUMP:py_client:1.3.0+canary.1] [BUMP:vscode_ext:0.5.0-canary.1] - #7
Merged
Merged
Conversation
…de_ext:0.5.0-canary.1]
hellovai
added a commit
that referenced
this pull request
Apr 16, 2026
Add test projects and LSP tests covering confirmed issues from PR review: - captured_field_chain: lambda capture roots (#1) and map fallback (#2) - generic_field_chain: generic type substitution (#3, deferred to separate PR) - deep_method_call: chained method call throw target (#5) - completions tests: chained field-access (#7) and lambda param (#8) - semantic token test: type-aware final segment classification (#9) Also accept lambda_advanced MIR snapshot (void→int type fix) and net.rs bytecode updates (call→dispatch_future). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryanmazzolini
added a commit
to ryanmazzolini/baml
that referenced
this pull request
Apr 21, 2026
…izer errors Three small cleanups from the Ruby CFFI migration review: - raw_object.rb cffi_method: add a docstring noting each generated method locks @Mutex and performs a full FFI round-trip, so reading N attributes is N round-trips and callers should not spin on them in tight loops. - raw_object.rb finalizer: drop the `if $DEBUG` guard on the error log so destructor failures surface on $stderr in production instead of vanishing silently. - media.rb: note that MediaObject.create is deliberately kept as the shared canonical factory because BamlRuntime#new_image et al. call it directly; the review's "inline and drop" suggestion was based on the misread that it only fed from_url/from_base64. Flagged in thoughts/ryan/reviews/2026-04-20-ruby-cffi-migration-review.md (Medium BoundaryML#7, Low BoundaryML#8, deviation from BoundaryML#9).
antoniosarosi
added a commit
that referenced
this pull request
May 4, 2026
- pull_semantics: debug_assert on the default `make_closure_with_type_args` so a sink that drops `ntypeargs` fails fast instead of silently modeling the wrong stack shape (#1). - mir/lower: `enclosing_generic_params()` now prepends class-level generics (matching TIR's `enclosing_class_generic_params ++ user` convention), so `reflect.type_of<T>()` and explicit `<T>` calls inside a method on `class Box<T>` lower to `TypeArgRef(N)` instead of silently emitting `Concrete(Void)` (#2, MIR side only — runtime ABI for class type-arg threading via the receiver is still TODO; documented on the helper). Two stdlib snapshots regenerated to reflect the now-correct lowering for `Stream<T,S>::final()` / `__sap_parse_partial<T,S>`. - tir/builder: add `Ty::Type { .. }` arm to `try_resolve_member_on_ty` so unions like `(cond ? type_of<A>() : type_of<B>()).to_string()` resolve via the `TypeValue` companion class (#4). - vm: gate the post-`Call` `type_args` writeback on `frames.len() > frames_before` so completed Native callees don't clobber the caller's frame, and `extend` rather than replace so a closure callee's `captured_type_args` are preserved with call-site args appended (#6, critical). - tests/load_type: tighten the concrete `LoadType` tests to match `Object::Type(ty)` against `Ty::int()`/`Ty::string()` and assert they differ, instead of accepting any `Value::Object(_)` (#7). - type_class / reflect_type_of: document `TypeValue.to_string()` as a stable identity key (package names are unique within a workspace, so the existing `Display` form is unambiguous) and add an end-to-end `map<string, V>` keyed-by-`type_of<T>().to_string()` test as the user-reachable analogue of `map<type, V>` (#8). - conversion: document the runtime gap that class-instance matching in `value_matches_type` and `find_matching_union_member` ignores `Ty::Class` type args because `Object::Instance` carries no resolved class type args — needed for proper union dispatch on parametric classes (#9, runtime side bundled with #2 follow-up).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated flow to bump version [BUMP:cli:0.4.0-canary.1] [BUMP:py_client:1.3.0+canary.1] [BUMP:vscode_ext:0.5.0-canary.1]