Skip to content

chore(ci): disable CodSpeed performance analysis - #3575

Merged
antoniosarosi merged 1 commit into
canaryfrom
antonio/disable-codspeed-ci
May 26, 2026
Merged

chore(ci): disable CodSpeed performance analysis#3575
antoniosarosi merged 1 commit into
canaryfrom
antonio/disable-codspeed-ci

Conversation

@antoniosarosi

@antoniosarosi antoniosarosi commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Drop the benchmarks-instrumented job from ci.yaml and remove it from the ci-failure-alert aggregator (needs list + summary table).
  • Clean up the now-stale benchmarks-instrumented / "codspeed builds" references in cargo-tests.reusable.yaml's cache-strategy comment.
  • CodSpeed is being replaced with an in-house benchmarking system.

The codspeed-divan-compat dev-deps in baml_language/Cargo.toml and engine/baml-vm/Cargo.toml are intentionally kept — they behave as a drop-in divan outside cargo codspeed builds, so local benchmarks still work. They can be swapped back to plain divan when the replacement lands.

Test plan

  • CI on this PR runs without the benchmarks-instrumented job and without ci-failure-alert referencing it.
  • If "CI - BAML Language / CI Failure Alert" is configured as a required status check, confirm it still resolves correctly (skipped-as-success) on green PRs.
  • Local cargo bench / cargo test --benches in baml_language still compiles and runs (sanity check that the codspeed-divan-compat drop-in still works without CodSpeed instrumentation).

Summary by CodeRabbit

  • Chores
    • Streamlined CI/CD infrastructure by removing redundant benchmark instrumentation job from the workflow pipeline.
    • Updated internal workflow configuration cache strategy documentation.

Review Change Stack

Drop the `benchmarks-instrumented` job (and its entry in the
`ci-failure-alert` aggregator) and clean up stale references in the
cargo-tests reusable workflow. CodSpeed is being replaced with an
in-house benchmarking system.

The `codspeed-divan-compat` dev-deps are intentionally left in place —
they behave as a drop-in `divan` outside `cargo codspeed` builds, so
local benchmarks still work. They can be swapped back to plain `divan`
when the replacement system lands.
@vercel

vercel Bot commented May 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
beps Ready Ready Preview, Comment May 26, 2026 11:13pm
promptfiddle Ready Ready Preview, Comment May 26, 2026 11:13pm
promptfiddle2 Ready Ready Preview, Comment May 26, 2026 11:13pm

Request Review

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8d0fdfdd-3e55-4df7-ab3d-467fe8b5dfed

📥 Commits

Reviewing files that changed from the base of the PR and between d393c6f and 6d98931.

📒 Files selected for processing (2)
  • .github/workflows/cargo-tests.reusable.yaml
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml

📝 Walkthrough

Walkthrough

This PR removes the benchmarks-instrumented CI job from the workflow and updates all related references in the ci-failure-alert job's dependencies and failure-reporting table, along with cleanup of cache documentation that no longer applies.

Changes

CI Job and Failure Alert Removal

Layer / File(s) Summary
Remove benchmarks-instrumented job and update ci-failure-alert
.github/workflows/ci.yaml
The benchmarks-instrumented job definition is removed from the workflow. The ci-failure-alert job's needs list is updated to exclude this job, and its failure-reporting markdown table is updated to remove the benchmarks-instrumented row from the status report.
Update cache strategy documentation
.github/workflows/cargo-tests.reusable.yaml
Cache strategy documentation for linux-cargo removes ci.yaml::benchmarks-instrumented from the documented shared-key readers list and removes the "codspeed builds" mention from the cache usage comment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • BoundaryML/baml#3543: Modified the benchmarks-instrumented job's CodSpeed step configuration before its removal.
  • BoundaryML/baml#3080: Made toolchain and shared cache key changes to the same benchmarks-instrumented job area.
  • BoundaryML/baml#3498: Updated caching configuration and shared cache keys related to the benchmarks-instrumented job.

Poem

🐰 A job once built with care and pride,
Now bids the CI workflow its goodbye.
Cache comments cleaned, references set free—
The benchmarks-instrumented runs no more, yee-hee! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and clearly describes the main change: disabling CodSpeed performance analysis by removing the benchmarks-instrumented job from CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch antonio/disable-codspeed-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Binary size checks passed

7 passed

Artifact Platform Gzip Baseline Delta Status
bridge_cffi Linux 6.6 MB 6.6 MB -4.8 KB (-0.1%) OK
bridge_cffi-stripped Linux 5.6 MB 5.7 MB -55.3 KB (-1.0%) OK
bridge_cffi macOS 5.4 MB 5.1 MB +337.4 KB (+6.6%) OK
bridge_cffi-stripped macOS 4.6 MB 4.7 MB -41.1 KB (-0.9%) OK
bridge_cffi Windows 5.4 MB 5.1 MB +274.7 KB (+5.4%) OK
bridge_cffi-stripped Windows 4.7 MB 4.7 MB +8.2 KB (+0.2%) OK
bridge_wasm WASM 3.6 MB 3.5 MB +56.1 KB (+1.6%) OK

Generated by cargo size-gate · workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant