Skip to content

No Case: Fixed the PPO runtime error metrics. - #86

Merged
Edilmo merged 5 commits into
releases/1.3.0from
rukon/ppo_fix
Aug 18, 2021
Merged

No Case: Fixed the PPO runtime error metrics.#86
Edilmo merged 5 commits into
releases/1.3.0from
rukon/ppo_fix

Conversation

@RuofanKong

Copy link
Copy Markdown

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Edilmo Edilmo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlyubim dmlyubim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this aggregation is tested, should be ok

@dmlyubim

Copy link
Copy Markdown

Be careful, though. I remember it was tricky for 0.8. There, the rllib only seemed to have captured partial metrics. I don't remember how it was deficient; but it was skipping over some evaluation -- either towers or SGD iterations, which resulted in missed first-chance errors. So better test with some degree of confidence there that deficient inputs do get captured as first-chance validation errors, not only some second chance errors when the weights are already garbage.

@RuofanKong

Copy link
Copy Markdown
Author

Assuming this aggregation is tested, should be ok

Yep! Your PDP2 runtime error test is a great resource to test through, while they're working now.

@Edilmo
Edilmo merged commit 0a69f8b into releases/1.3.0 Aug 18, 2021
@Edilmo
Edilmo deleted the rukon/ppo_fix branch August 18, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants