No Case: Fixed the PPO runtime error metrics. - #86
Merged
Conversation
added 2 commits
August 17, 2021 01:16
dmlyubim
approved these changes
Aug 17, 2021
dmlyubim
left a comment
There was a problem hiding this comment.
Assuming this aggregation is tested, should be ok
|
Be careful, though. I remember it was tricky for 0.8. There, the rllib only seemed to have captured partial metrics. I don't remember how it was deficient; but it was skipping over some evaluation -- either towers or SGD iterations, which resulted in missed first-chance errors. So better test with some degree of confidence there that deficient inputs do get captured as first-chance validation errors, not only some second chance errors when the weights are already garbage. |
bimalkmehta
approved these changes
Aug 17, 2021
Author
Yep! Your PDP2 runtime error test is a great resource to test through, while they're working now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.