fix(android): bind scan without ImageCapture on LIMITED cameras - #8
Open
GladosBlueWallet wants to merge 11 commits into
Open
fix(android): bind scan without ImageCapture on LIMITED cameras#8GladosBlueWallet wants to merge 11 commits into
GladosBlueWallet wants to merge 11 commits into
Conversation
…-build-output Exclude generated build output from npm package
Add face detection
Preview+ImageCapture+ImageAnalysis fails to bind on many LIMITED cameras (emulator webcams especially), leaving a black preview. When scanning or detecting faces, bind Preview+ImageAnalysis only, skip view-derived aspect ratio on Preview, and target VGA for analysis. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sister of teslamotors/react-native-camera-kit#809.
Same CameraX bind issue: on LIMITED cameras (emulator webcams),
Preview+ImageCapture+ImageAnalysisfails with a black preview.When
scanBarcodeis on:setTargetAspectRatioon PreviewPhoto-capture path unchanged.
Fork-only: harden
QRCodeAnalyzerY-plane extraction forpixelStride(limpbrains/qr; Tesla uses ML Kit).After teslamotors#809 lands upstream, catching up this fork should be mostly a clean port of the shared
CKCamerahunk. BlueWallet can then bump the pin and drop the localpatch-packageworkaround.Test plan
scanBarcodeoff) still worksMade with Cursor