feat(statics): give Sepolia testnet its own underlying asset (sepETH) - #9389
Open
rithwik-bitgo wants to merge 1 commit into
Open
feat(statics): give Sepolia testnet its own underlying asset (sepETH)#9389rithwik-bitgo wants to merge 1 commit into
rithwik-bitgo wants to merge 1 commit into
Conversation
Contributor
rithwik-bitgo
force-pushed
the
CECHO-1721-sepeth
branch
from
July 30, 2026 08:07
0f0b61e to
dd2254b
Compare
rithwik-bitgo
marked this pull request as ready for review
July 30, 2026 08:12
Contributor
CI unblock: stx sign/verify fixture
Commit: |
@stacks/transactions signWithKey passes the message to elliptic as hex. With bn.js@5 (CI when elliptic's nested bn.js@4 is not used), non-hex messages like 'hello' throw. Switch message2 to valid hex and regenerate the expected signature so unit tests pass under either layout. TICKET: CECHO-1721
rithwik-bitgo
force-pushed
the
CECHO-1721-sepeth
branch
from
July 30, 2026 11:06
a4d99fc to
c814abc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
11155111) as a testnet-only network for Ethereum, following the existinggteth/htethpattern (CoinFamily.ETH, no mainnet counterpart since Sepolia is Ethereum's own test network).UnderlyingAsset.SEPETHinstead of reusingUnderlyingAsset.ETH, so it's distinguishable as its own asset while still sharing theethfamily/signing implementation.sepeth("Sepolia Testnet Ethereum"). OFC entry:ofctsepeth(keptofct-prefixed to satisfy the OFC testnet naming-convention test).Notes
batcherContractAddress/forwarderFactoryAddress/forwarderImplementationAddressare intentionally omitted (optional fields onEthereumNetwork) since BitGo's forwarder/batcher contracts haven't been deployed on Sepolia yet — to be added once contract deployment is complete.SEPETHa fully standaloneCoinFamily, but reverted:getEthLikeTokens(AMS token config tooling) requires every family with an EVM-feature coin to have a canonical mainnet coin named exactly like the family, which a testnet-only chain can't satisfy without adding a fake mainnet entry. Keepingfamily = CoinFamily.ETHavoids that while still giving Sepolia its own asset identity.networkFeatureMapForTokens.ts(already covers theethfamily) orenvironments.ts(its explorer config is a single shared endpoint per environment, not per-testnet).CI fix (unrelated to Sepolia)
unit-testwas failing in@bitgo/sdk-coin-stx(Invalid character in hello) afterbn.jswas bumped to5.2.3(WCN-1224 / chore: update bn.js to version 5.2.3 in package.json and yarn.lock #9349).@stacks/transactionssignWithKeypasses the message to elliptic as hex. Test fixturemessage2 = 'hello'is not valid hex; it only passed when elliptic resolved its nested lenientbn.js@4.sdk-coin-stxfixtures —message2→ valid hexdeadbeef, regeneratedexpectedSignature2. No production signing behavior change.TICKET: CECHO-1721
Test plan
yarn workspace @bitgo/statics run unit-test— all 33k+ tests passingtsc --noEmittypecheck clean formodules/staticsyarn workspace @bitgo/sdk-coin-stx run unit-test— sign/verify fixtures pass under bn.js@5