add StructField Metadata support#19
Merged
Merged
Conversation
kmate
approved these changes
Jan 29, 2018
nz87
approved these changes
Jan 29, 2018
|
Based on #18, AFAIK. |
|
why did you create a separate PR for this? |
|
It is a different feature. |
kmate
reviewed
Jan 29, 2018
|
|
||
| import scala.collection.generic.IsTraversableOnce | ||
|
|
||
| final class MetaData(val metadata: Metadata) extends StaticAnnotation |
There was a problem hiding this comment.
Can we rename this to @Meta just to make usage shorter?
kmate
approved these changes
Jan 29, 2018
BenFradet
reviewed
Jan 31, 2018
|
|
||
| import scala.collection.generic.IsTraversableOnce | ||
|
|
||
| final class Meta(val metadata: Metadata) extends StaticAnnotation |
There was a problem hiding this comment.
I think yes, because it is not a case class and we need to access this field later to extract the value.
Owner
There was a problem hiding this comment.
My bad read this as a case class, merging thanks a lot!
BenFradet
approved these changes
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.