Skip to content

Add validation baseline exclusions#3684

Merged
JoshLozensky merged 1 commit into
masterfrom
lozensky/FixPackingIssues
Jan 28, 2026
Merged

Add validation baseline exclusions#3684
JoshLozensky merged 1 commit into
masterfrom
lozensky/FixPackingIssues

Conversation

@JoshLozensky

@JoshLozensky JoshLozensky commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Replacing validation exclusions removed in PR #3659, these are needed to avoid packing errors when packing the GraphServiceClient project which has a different baseline validation version number from the rest of Id Web

@JoshLozensky JoshLozensky requested a review from a team as a code owner January 28, 2026 02:55
@jmprieur

Copy link
Copy Markdown
Collaborator

Why would GraphServiceClient have a different version number?

@JoshLozensky

JoshLozensky commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

@jmprieur I misspoke in the description and have edited to clarify that the different version is for baseline validation of the package, not a different version for the package itself. I'm seeing that the clientsemver used to be directly set in the csproj for the GraphServiceClient package and that is when the package-specific baseline validation was added as well. I'll try removing the unique baseline validation version from the package and test in another branch, merging this one so the build is fixed asap.

@JoshLozensky JoshLozensky merged commit 5c87b5c into master Jan 28, 2026
5 checks passed
@JoshLozensky JoshLozensky deleted the lozensky/FixPackingIssues branch January 28, 2026 17:43
@jmprieur

Copy link
Copy Markdown
Collaborator

Its not clear to me what changed

This was referenced Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants