Encapsulating multiple dictionaries parsed from DbDataReader handler into a class - #1224
Merged
Ayush Agarwal (ayush3797) merged 11 commits intoFeb 16, 2023
Conversation
Ayush Agarwal (ayush3797)
changed the title
added 2 commits
February 14, 2023 12:10
…tps://github.com/Azure/data-api-builder into dev/agarwalayush/encloseReturnFromDbDataHandlers
Ayush Agarwal (ayush3797)
marked this pull request as ready for review
February 14, 2023 07:03
Ayush Agarwal (ayush3797)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Abhishek Kumar (abhishekkumams),
Gledis Zeneli (gledis69),
Jun Su (junsu0ms),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Ravi Shetye (ravishetye),
Sean Leonard (seantleonard),
Shyam Sundar J (severussundar) and
tarazou9
as code owners
February 14, 2023 07:03
Collaborator
Aniruddh Munde (Aniruddh25)
approved these changes
Feb 15, 2023
Sean Leonard (seantleonard)
requested changes
Feb 15, 2023
…tps://github.com/Azure/data-api-builder into dev/agarwalayush/encloseReturnFromDbDataHandlers
Ayush Agarwal (ayush3797)
enabled auto-merge (squash)
February 16, 2023 06:38
Sean Leonard (seantleonard)
approved these changes
Feb 16, 2023
Sean Leonard (seantleonard)
left a comment
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
Thank you for addressing and considering review comments!
Ayush Agarwal (ayush3797)
deleted the
dev/agarwalayush/encloseReturnFromDbDataHandlers
branch
February 16, 2023 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Fixes: #819
What is this change?
Enclosed return from DbDataReader handlers into a class
DbOperationResultRow.How was this tested?
Just a refactor. Passing of existing test cases validate the change.