Remove Spring Milestone repository - #49523
Merged
Alan Zimmer (alzimmermsft) merged 3 commits intoJun 18, 2026
Merged
Conversation
Rujun Chen (rujche)
requested review from
a team,
Jonathan Giles (JonathanGiles),
Alan Zimmer (alzimmermsft),
Sameeksha Vaity (samvaity) and
Srikanta (srnagar)
as code owners
June 17, 2026 01:16
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the Maven profile that adds the Spring Milestone repository from the azure-client-sdk-parent parent POM, aligning the build with the intent to stop using that external repository as pipelines move toward restricted network access.
Changes:
- Deleted the
external-dependency-version-overridesMaven profile that configuredhttps://repo.spring.io/milestonefor version override test runs.
Rujun Chen (rujche)
force-pushed
the
rujche/main/remove-spring-milestone-repository
branch
from
June 17, 2026 01:25
6e1b399 to
0435a0b
Compare
Rujun Chen (rujche)
requested review from
Ben Broderick Phillips (benbp) and
Mike Harder (mikeharder)
as code owners
June 17, 2026 01:26
Co-authored-by: rujche <171773178+rujche@users.noreply.github.com>
Ray Chen (raych1)
approved these changes
Jun 18, 2026
Alan Zimmer (alzimmermsft)
approved these changes
Jun 18, 2026
Alan Zimmer (alzimmermsft)
deleted the
rujche/main/remove-spring-milestone-repository
branch
June 18, 2026 13:26
github-project-automation
Bot
moved this from In Progress
to Done
in Spring Cloud Azure
Abhijeet Mohanty (jeet1995)
added a commit
to jeet1995/azure-sdk-for-java
that referenced
this pull request
Aug 30, 2026
Backport PR Azure#49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents.
Abhijeet Mohanty (jeet1995)
added a commit
to jeet1995/azure-sdk-for-java
that referenced
this pull request
Aug 30, 2026
Backport PR Azure#49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents.
Abhijeet Mohanty (jeet1995)
added a commit
to jeet1995/azure-sdk-for-java
that referenced
this pull request
Aug 30, 2026
Backport PR Azure#49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents.
Abhijeet Mohanty (jeet1995)
added a commit
that referenced
this pull request
Sep 4, 2026
* Fix partitionLevelCircuitBreakerCfg missing from CosmosDiagnostics clientCfgs The partitionLevelCircuitBreakerCfg field disappeared from the clientCfgs section of CosmosDiagnostics when a customer explicitly enabled Per-Partition Circuit Breaker (PPCB) client-side. Root cause: the diagnostics write was coupled to the Per-Partition Automatic Failover (PPAF) initialization path, so the field was only populated when the service mandated PPAF, not when PPCB was configured client-side. Fix: move the diagnostics write into initializePerPartitionCircuitBreaker(), which is invoked unconditionally at client init, so the field appears whenever the circuit breaker is configured client-side. Adds a CI-runnable regression test asserting all clientCfgs keys are present, including partitionLevelCircuitBreakerCfg. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address Copilot review: use strictly valid JSON in PPCB test system property Remove trailing comma before closing brace in the COSMOS.PARTITION_LEVEL_CIRCUIT_BREAKER_CONFIG JSON so the value is strictly valid and clearer as a customer reference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add changelog entry for PPCB diagnostics fix Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add PPCB clientCfgs diagnostics validation to PerPartitionCircuitBreakerE2ETests Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Run PPCB clientCfgs diagnostics E2E test across all TestNG groups Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Simplify PPCB E2E diagnostics test to verify unconditional clientCfgs keys The partitionLevelCircuitBreakerCfg field now appears in clientCfgs for every client regardless of PPCB configuration, so the E2E test no longer sets the COSMOS.PARTITION_LEVEL_CIRCUIT_BREAKER_CONFIG system property. It just builds a plain client and asserts all expected clientCfgs keys (including partitionLevelCircuitBreakerCfg) are present in CosmosDiagnostics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Simplify PPCB unit test to assert clientCfgs key presence only Remove PPCB System.setProperty/clearProperty and the value-specific assertion; assert only that all clientCfgs keys are present, matching the E2E test simplification. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix PPCB failback with missing or stale addresses (#50182) * Fix PPCB failback with missing or stale addresses --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix PPCB diagnostics and failback observability. (#50158) * Improve PPCB failback diagnostics * Validate PPCB state in diagnostics E2E tests * Limit PPCB diagnostics assertion to data-plane requests * Log PPCB failback backlog progress * Add PPCB failback remaining meter * Clarify PPCB failback meter name * Reduce PPCB failback meter allocations * Track PPCB pending recoveries by collection * Correlate PPCB failback recovery diagnostics * Harden PPCB failback recovery tests * Fix PPCB all-region diagnostics assertion * Optimize PPCB diagnostics snapshots * Cache PPCB diagnostics snapshots * Align PPCB failback flow with main * Add benchmark fault injection support. * Harden PPCB failback telemetry Use a single injectable logger, prevent backlog telemetry failures from escaping the recovery flow, and align the pending failback metric name. * Scope PR to PPCB diagnostics Remove benchmark, fault-injection, metric, and recovery behavior changes. Retain immutable CosmosDiagnostics PPCB snapshots, lifecycle E2E assertions, and WARN logging for every failback failure. * Reduce PPCB diagnostics overhead Reuse immutable PPCB map references in response snapshots and shorten per-region diagnostic field names. * Refactoring * Simplify PPCB diagnostics snapshots Represent holder state with one volatile immutable-map reference and align the compact timestamp serialization test. * Ignore updates to empty PPCB diagnostics Make updates to the shared uninitialized diagnostics sentinel a no-op and verify it remains null-serializing. * Avoid copying PPCB diagnostics state Retain the live PPCB diagnostics map reference to avoid per-publication map and wrapper allocations, accepting weak consistency. * Log PPCB diagnostics lifecycle snapshots Emit one full CosmosDiagnostics JSON payload for failed, post-failover, and post-failback E2E phases for PR evidence. * Document PPCB diagnostics improvements Add the unreleased changelog entry for per-region PPCB snapshots and failback WARN logging. * Add PPCB failback outcome diagnostics Track the latest background failback attempt time, outcome, and failure reason per partition-region; validate lifecycle state in E2E and focused recovery tests. * Reset unavailable timestamp after PPCB failback Use the available-state sentinel when recovery moves a region to HealthyTentative and cover it in the scheduled recovery test. * Refine PPCB failback diagnostics Keep failback attempt metadata partition-scoped, retain only the latest full failure message per region, and clear retained messages when recovery backlog drains. * Prepare azure-cosmos 4.79.1-hotfix backport Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Adapt PPCB tests for azure-cosmos 4.79 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Restore PPCB hotfix regression coverage * Backport customer workflow tests from PR #49568 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Use authenticated Maven mirror in pipelines Complete the existing pipeline authentication flow with mirror settings so network-isolated agents resolve Maven dependencies through the Azure SDK feed. * Run LatestCommitted workflow in Direct mode Exclude the unsupported Gateway factory case while retaining Direct-mode LatestCommitted customer workflow coverage. * Fix hotfix test and Kafka pipeline compatibility Restrict Gateway customer workflows that require later ReadConsistencyStrategy support, route Confluent dependencies through authenticated CFS, and authenticate Testcontainers image pulls through ACR. * Route Spring Maven repository through CFS Backport PR #49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents. * Retry reads until one region is contacted * Remove Confluent serializer dependency from Kafka tests * Fix hotfix CI dependency validation * Fix test proxy startup on macOS * Remove unused Confluent dependency version * Authenticate pipeline tooling dependencies * Route NuGet through Azure Artifacts * Authenticate cspell npm dependencies * Skip TypeSpec code generation verification * Skip FromSource tests in Cosmos CI * Backport Cosmos test infrastructure updates Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Remove unsupported non-canonical region PPCB test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Date azure-cosmos 4.79.1-hotfix release Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350
Abhijeet Mohanty (jeet1995)
added a commit
that referenced
this pull request
Sep 4, 2026
* Fix PPCB failback with missing or stale addresses (#50182) * Fix PPCB failback with missing or stale addresses --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix PPCB diagnostics and failback observability. (#50158) * Improve PPCB failback diagnostics * Validate PPCB state in diagnostics E2E tests * Limit PPCB diagnostics assertion to data-plane requests * Log PPCB failback backlog progress * Add PPCB failback remaining meter * Clarify PPCB failback meter name * Reduce PPCB failback meter allocations * Track PPCB pending recoveries by collection * Correlate PPCB failback recovery diagnostics * Harden PPCB failback recovery tests * Fix PPCB all-region diagnostics assertion * Optimize PPCB diagnostics snapshots * Cache PPCB diagnostics snapshots * Align PPCB failback flow with main * Add benchmark fault injection support. * Harden PPCB failback telemetry Use a single injectable logger, prevent backlog telemetry failures from escaping the recovery flow, and align the pending failback metric name. * Scope PR to PPCB diagnostics Remove benchmark, fault-injection, metric, and recovery behavior changes. Retain immutable CosmosDiagnostics PPCB snapshots, lifecycle E2E assertions, and WARN logging for every failback failure. * Reduce PPCB diagnostics overhead Reuse immutable PPCB map references in response snapshots and shorten per-region diagnostic field names. * Refactoring * Simplify PPCB diagnostics snapshots Represent holder state with one volatile immutable-map reference and align the compact timestamp serialization test. * Ignore updates to empty PPCB diagnostics Make updates to the shared uninitialized diagnostics sentinel a no-op and verify it remains null-serializing. * Avoid copying PPCB diagnostics state Retain the live PPCB diagnostics map reference to avoid per-publication map and wrapper allocations, accepting weak consistency. * Log PPCB diagnostics lifecycle snapshots Emit one full CosmosDiagnostics JSON payload for failed, post-failover, and post-failback E2E phases for PR evidence. * Document PPCB diagnostics improvements Add the unreleased changelog entry for per-region PPCB snapshots and failback WARN logging. * Add PPCB failback outcome diagnostics Track the latest background failback attempt time, outcome, and failure reason per partition-region; validate lifecycle state in E2E and focused recovery tests. * Reset unavailable timestamp after PPCB failback Use the available-state sentinel when recovery moves a region to HealthyTentative and cover it in the scheduled recovery test. * Refine PPCB failback diagnostics Keep failback attempt metadata partition-scoped, retain only the latest full failure message per region, and clear retained messages when recovery backlog drains. * Fix partitionLevelCircuitBreakerCfg missing from CosmosDiagnostics clientCfgs The partitionLevelCircuitBreakerCfg field disappeared from the clientCfgs section of CosmosDiagnostics when a customer explicitly enabled Per-Partition Circuit Breaker (PPCB) client-side. Root cause: the diagnostics write was coupled to the Per-Partition Automatic Failover (PPAF) initialization path, so the field was only populated when the service mandated PPAF, not when PPCB was configured client-side. Fix: move the diagnostics write into initializePerPartitionCircuitBreaker(), which is invoked unconditionally at client init, so the field appears whenever the circuit breaker is configured client-side. Adds a CI-runnable regression test asserting all clientCfgs keys are present, including partitionLevelCircuitBreakerCfg. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Address Copilot review: use strictly valid JSON in PPCB test system property Remove trailing comma before closing brace in the COSMOS.PARTITION_LEVEL_CIRCUIT_BREAKER_CONFIG JSON so the value is strictly valid and clearer as a customer reference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add PPCB clientCfgs diagnostics validation to PerPartitionCircuitBreakerE2ETests Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Run PPCB clientCfgs diagnostics E2E test across all TestNG groups Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Simplify PPCB E2E diagnostics test to verify unconditional clientCfgs keys The partitionLevelCircuitBreakerCfg field now appears in clientCfgs for every client regardless of PPCB configuration, so the E2E test no longer sets the COSMOS.PARTITION_LEVEL_CIRCUIT_BREAKER_CONFIG system property. It just builds a plain client and asserts all expected clientCfgs keys (including partitionLevelCircuitBreakerCfg) are present in CosmosDiagnostics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Simplify PPCB unit test to assert clientCfgs key presence only Remove PPCB System.setProperty/clearProperty and the value-specific assertion; assert only that all clientCfgs keys are present, matching the E2E test simplification. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Prepare azure-cosmos 4.76.1-hotfix backport Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Restore PPCB hotfix regression coverage * Backport customer workflow tests from PR #49568 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Use authenticated Maven mirror in pipelines Route CI and live-test Maven dependency resolution through the authenticated Azure SDK feed so network-isolated agents do not access Maven Central directly. * Run LatestCommitted workflow in Direct mode Exclude the unsupported Gateway factory case while retaining Direct-mode LatestCommitted customer workflow coverage. * Fix hotfix test and Kafka pipeline compatibility Restrict unsupported customer workflow modes, initialize PPCB fixtures for the thin-client group, route Confluent dependencies through authenticated CFS, and authenticate Testcontainers image pulls through ACR. * Route Spring Maven repository through CFS Backport PR #49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents. * Retry reads until one region is contacted * Remove Confluent serializer dependency from Kafka tests * Fix hotfix CI dependency validation * Fix test proxy startup on macOS * Remove unused Confluent dependency version * Authenticate Maven in hotfix CI jobs * Authenticate pipeline tooling dependencies * Route NuGet through Azure Artifacts * Skip FromSource tests in Cosmos CI * Backport Cosmos test infrastructure updates Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Date azure-cosmos 4.76.1-hotfix release Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350
Abhijeet Mohanty (jeet1995)
added a commit
that referenced
this pull request
Sep 4, 2026
* Fix PPCB failback with missing or stale addresses (#50182) * Fix PPCB failback with missing or stale addresses --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix PPCB diagnostics and failback observability. (#50158) * Improve PPCB failback diagnostics * Validate PPCB state in diagnostics E2E tests * Limit PPCB diagnostics assertion to data-plane requests * Log PPCB failback backlog progress * Add PPCB failback remaining meter * Clarify PPCB failback meter name * Reduce PPCB failback meter allocations * Track PPCB pending recoveries by collection * Correlate PPCB failback recovery diagnostics * Harden PPCB failback recovery tests * Fix PPCB all-region diagnostics assertion * Optimize PPCB diagnostics snapshots * Cache PPCB diagnostics snapshots * Align PPCB failback flow with main * Add benchmark fault injection support. * Harden PPCB failback telemetry Use a single injectable logger, prevent backlog telemetry failures from escaping the recovery flow, and align the pending failback metric name. * Scope PR to PPCB diagnostics Remove benchmark, fault-injection, metric, and recovery behavior changes. Retain immutable CosmosDiagnostics PPCB snapshots, lifecycle E2E assertions, and WARN logging for every failback failure. * Reduce PPCB diagnostics overhead Reuse immutable PPCB map references in response snapshots and shorten per-region diagnostic field names. * Refactoring * Simplify PPCB diagnostics snapshots Represent holder state with one volatile immutable-map reference and align the compact timestamp serialization test. * Ignore updates to empty PPCB diagnostics Make updates to the shared uninitialized diagnostics sentinel a no-op and verify it remains null-serializing. * Avoid copying PPCB diagnostics state Retain the live PPCB diagnostics map reference to avoid per-publication map and wrapper allocations, accepting weak consistency. * Log PPCB diagnostics lifecycle snapshots Emit one full CosmosDiagnostics JSON payload for failed, post-failover, and post-failback E2E phases for PR evidence. * Document PPCB diagnostics improvements Add the unreleased changelog entry for per-region PPCB snapshots and failback WARN logging. * Add PPCB failback outcome diagnostics Track the latest background failback attempt time, outcome, and failure reason per partition-region; validate lifecycle state in E2E and focused recovery tests. * Reset unavailable timestamp after PPCB failback Use the available-state sentinel when recovery moves a region to HealthyTentative and cover it in the scheduled recovery test. * Refine PPCB failback diagnostics Keep failback attempt metadata partition-scoped, retain only the latest full failure message per region, and clear retained messages when recovery backlog drains. * Prepare azure-cosmos 4.71.3-hotfix backport Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Backport PPCB diagnostics client config fix (#49734) * Restore PPCB hotfix regression coverage * Backport customer workflow tests from PR #49568 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Use authenticated Maven mirror in pipelines Route CI and live-test Maven dependency resolution through the authenticated Azure SDK feed so network-isolated agents do not access Maven Central directly. * Authenticate Maven in remaining pipeline jobs Replace all remaining reporting-tools warmup calls with the authenticated Azure Artifacts Maven setup so version, native, validation, aggregate, and patch pipeline jobs work under network isolation. * Remove obsolete reporting setup from Cosmos pipelines Rely on shared authenticated Maven setup in isolated test jobs instead of injecting the network-isolation-incompatible reporting-tools warmup from Cosmos test and Kafka pipelines. * Run LatestCommitted workflow in Direct mode Exclude the unsupported Gateway factory case while retaining Direct-mode LatestCommitted customer workflow coverage. * Fix hotfix test and Kafka pipeline compatibility Restrict unsupported customer workflow modes, initialize PPCB fixtures for the thin-client group, route Confluent dependencies through authenticated CFS, and authenticate Testcontainers image pulls through ACR. * Route Spring Maven repository through CFS Backport PR #49523's mirror correction so Spring Milestone cannot bypass the authenticated Azure Artifacts mirror on isolated agents. * Retry reads until one region is contacted * Remove Confluent serializer dependency from Kafka tests * Fix hotfix CI dependency validation * Fix test proxy startup on macOS * Remove unused Confluent dependency version * Authenticate Maven in hotfix CI jobs * Authenticate pipeline tooling dependencies * Skip code quality linting for 4.71.3 hotfix * Skip 4.71.3 code quality job * Route NuGet through Azure Artifacts * Remove unavailable leak detector listener * Remove Thin Client HTTP2 workflow matrix cases * Backport Cosmos test infrastructure updates Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Date azure-cosmos 4.71.3-hotfix release Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350 * Fix tests. --------- Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16ce0941-555c-4190-8c4d-96c705086350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines