Improve mgmt-review workflow - #27502
Merged
Chenjie Shi (tadelesh) merged 3 commits intoSep 7, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 6 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
ZiWei Chen (kazrael2119)
September 2, 2026 06:40
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fallback can incorrectly approve an unapproved namespace using the workflow’s own comment.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Broadens namespace approval fallback signals to accept issue or specification PR links from any commenter.
Changes:
- Expands accepted manual approval links.
- Updates onboarding guidance and examples.
File summaries
| File | Review |
|---|---|
.github/workflows/mgmt-review.md |
Critical: The workflow can treat its own checklist comment as approval. Exclude comments containing the workflow marker before evaluating manual signals. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
ZiWei Chen (kazrael2119)
September 2, 2026 06:56
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The stale workflow lock may fail validation and must be regenerated.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
Copilot started reviewing on behalf of
ZiWei Chen (kazrael2119)
September 2, 2026 07:06
View session
Jiaqi Zhang (JiaqiZhang-Dev)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the namespace approval fallback logic to accept comments from any user when they mention namespace and include a GitHub issue or pull request link. Since namespace reviews may now occur directly during specification PR review, links to azure-rest-api-specs pull requests are treated as valid approval signals while retaining support and examples for namespace review issue links.