[Network] az network private-endpoint-connection: Add provider Microsoft.HardwareSecurityModules/paymentHsmClusters - #33889
Conversation
…oft.HardwareSecurityModules/cloudHsmClusters
…-paymenthsmclusters
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR extends the network command module’s private-link provider mapping to support Microsoft.HardwareSecurityModules/paymentHsmClusters and adds scenario coverage to validate private-link-resource listing and private-endpoint-connection operations for Payment HSM clusters.
Changes:
- Register
Microsoft.HardwareSecurityModules/paymentHsmClusterswith API version2025-12-01-previewfor private link scenarios. - Add new scenario tests for Payment HSM private-link-resource listing and private-endpoint-connection lifecycle (list/show/approve/reject/delete).
- Add test recordings for the new scenarios.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/network/private_link_resource_and_endpoint_connections/custom.py |
Adds provider registration for paymentHsmClusters so private-link commands can resolve API versions/behavior. |
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py |
Adds scenario tests covering Payment HSM private link resource discovery and PEC operations. |
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_phsm_private_link_resource.yaml |
Recording for the new private-link-resource scenario test. |
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_phsm_private_endpoint_connection.yaml |
Recording for the new private-endpoint-connection scenario test. |
Suppressed comments (1)
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_private_endpoint_commands.py:4808
- This approve call also hard-codes the resource type; using '{type}' avoids duplicating the RP string and keeps the test aligned with earlier params.
'-g {rg} '
'--type Microsoft.HardwareSecurityModules/paymentHsmClusters '
'--description "{approval_desc}"',
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
az network private-endpoint-connection: Add provider Microsoft.HardwareSecurityModules/paymentHsmClusters
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Demilade Oladugba (@D-Alegria) regarding to https://dev.azure.com/azclitools/public/_build/results?buildId=338025&view=logs&j=774b165a-3d68-5106-ba2f-cfafadcd5213&t=2901d615-8692-5339-11c9-33bc3b789f59&l=1417, could you please pull the latest dev branch and |
…-paymenthsmclusters
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
🤖 PR Validation —⚠️ Review suggested
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.