Skip to content

Fix snapshot reference resolution order#182

Merged
linglingye001 merged 1 commit into
release/v2.6.3from
linglingye/fix-snapshot-ref
Jun 4, 2026
Merged

Fix snapshot reference resolution order#182
linglingye001 merged 1 commit into
release/v2.6.3from
linglingye/fix-snapshot-ref

Conversation

@linglingye001

@linglingye001 linglingye001 commented Jun 3, 2026

Copy link
Copy Markdown
Member

Fix #180

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts snapshot reference handling in the configuration settings loader so snapshot-referenced settings are resolved and processed inline, preserving their intended position in the overall selector/setting precedence order.

Changes:

  • Replace deferred snapshot reference collection + post-processing with inline snapshot resolution inside processSettings.
  • Introduce allowSnapshotRef to prevent nested snapshot reference resolution and snapshotClient to lazily initialize/reuse an App Configuration client for snapshot reads.
  • Remove the now-unneeded resolveSnapshotReferences helper and update in-code documentation to reflect the new behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zhenlan

zhenlan commented Jun 3, 2026

Copy link
Copy Markdown
Member
  • Introduce allowSnapshotRef to prevent nested snapshot reference resolution and snapshotClient to lazily initialize/reuse an App Configuration client for snapshot reads.

@linglingye001 does it mean a user can disable snapshot reference resolution? Do we support the similar switch in other providers?

@linglingye001

Copy link
Copy Markdown
Member Author
  • Introduce allowSnapshotRef to prevent nested snapshot reference resolution and snapshotClient to lazily initialize/reuse an App Configuration client for snapshot reads.

@linglingye001 does it mean a user can disable snapshot reference resolution? Do we support the similar switch in other providers?

No, allowSnapshotRef is an internal variable. The k8s provider parses the snapshot references in processSettings, fetches the snapshot's settings, allowSnapshotRef false inside a nested snapshot's settings to prevent recursive resolution.

@linglingye001 linglingye001 merged commit cb88f16 into release/v2.6.3 Jun 4, 2026
4 checks passed
@linglingye001 linglingye001 deleted the linglingye/fix-snapshot-ref branch June 4, 2026 09:24
linglingye001 added a commit that referenced this pull request Jun 23, 2026
* fix snapshot reference resolution order (#182)

* Update dependencies and bump version to 2.6.3 (#183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants