Newsletter: Remove duplicate text from newsletter settings

[mehmoodak]

Closes: https://linear.app/a8c/issue/NL-784

Proposed changes

In Newsetter Settings, a “Subscribe modal heading” card is displaying the same text in the field description and help text. We removed the duplication.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

• Checkout this PR on sandbox.
• Sandbox the site you want to test.
• Go to Jetpack > Newsletter > Settings > Subscribe modal heading
• Verify the text duplication is fixed now.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the NL-784/remove-duplicate-text-from-newsletter-settings branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack NL-784/remove-duplicate-text-from-newsletter-settings

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[mehmoodak]

AI Code Review:

  +------------------------------------------------------------------+--------+
  | Check                                                            | Result |
  +------------------------------------------------------------------+--------+
  | Follows WordPress coding standards and best practices            |   ✅   |
  | No security issues (escaping, sanitization, SQL, XSS, auth)      |   ✅   |
  | No new warnings, fatals, errors, or type errors (PHP/TS)         |   ✅   |
  | Function calls verified (exist, correct params, return handled)  |   ✅   |
  | No potential mid-deploy issues                                   |   ✅   |
  | Follows existing patterns in the repo                            |   ✅   |
  | i18n handled (translations, text domain, plural forms)           |   ✅   |
  | Accessibility (a11y) handled for UI changes                      |   ✅   |
  | No performance or caching regressions                            |  N/A   |
  | Backwards compatible (filters, hooks, REST, exports, schema)     |  N/A   |
  +------------------------------------------------------------------+--------+

  Risk Assessment: **LOW**
  Approval Percentage: **98%**

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report