Skip to content

Fix toolbar button shortcut (#1274) - #1288

Merged
mymindstorm merged 1 commit into
Authenticator-Extension:devfrom
cesar19004:dev
Sep 3, 2024
Merged

Fix toolbar button shortcut (#1274)#1288
mymindstorm merged 1 commit into
Authenticator-Extension:devfrom
cesar19004:dev

Conversation

@cesar19004

@cesar19004 cesar19004 commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

Fix #1274 Since manifest v3 execute_browser_action is no longer available, use the execute_action command instead
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands

Since manifest v3 `execute_browser_action` is no longer available, use the `execute_action` command instead
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands
@cesar19004 cesar19004 changed the title Fix #1274 Fix toolbar button shortcut (#1274) Sep 1, 2024
@Sneezry
Sneezry requested a review from mymindstorm September 2, 2024 04:13
@Sneezry

Sneezry commented Sep 2, 2024

Copy link
Copy Markdown
Member

@mymindstorm I think I missed this migration for Firefox in #1009 . Could you help to double confirm? Thanks.

@mymindstorm mymindstorm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mymindstorm
mymindstorm merged commit 8083b0a into Authenticator-Extension:dev Sep 3, 2024
mymindstorm pushed a commit that referenced this pull request Sep 15, 2024
Since manifest v3 `execute_browser_action` is no longer available, use the `execute_action` command instead
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot set toolbar hotkey

3 participants