Skip to content

use Atliac/pr-welcome - #10

Merged
Atliac merged 1 commit into
mainfrom
pr-welcome
Jun 21, 2026
Merged

use Atliac/pr-welcome#10
Atliac merged 1 commit into
mainfrom
pr-welcome

Conversation

@Atliac

@Atliac Atliac commented Jun 21, 2026

Copy link
Copy Markdown
Owner

No description provided.

Signed-off-by: Atliac <Atliac@outlook.com>
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated pull request welcome automation workflow to use a standardized integration for improved maintainability and consistency.

Walkthrough

The .github/workflows/pr-welcome.yml workflow is simplified by replacing the inline actions/github-script@v7 logic (which built and posted a welcome comment with duplicate detection) with a single invocation of the Atliac/pr-welcome@v1 action. The trigger is changed from pull_request (opened, ready_for_review) to pull_request_target (opened), and explicit issues: write and pull-requests: write permissions are added.

Changes

PR Welcome Workflow Simplification

Layer / File(s) Summary
Workflow trigger, permissions, and action delegation
.github/workflows/pr-welcome.yml
Trigger changed from pull_request to pull_request_target scoped to opened only; explicit write permissions added; entire inline GitHub Script comment-building and duplicate-check logic removed and replaced with a single Atliac/pr-welcome@v1 step using GITHUB_TOKEN.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Atliac/crate-template#5: Directly related — this PR replaces the inline actions/github-script duplicate-detection and comment-construction logic introduced or modified in that PR with the Atliac/pr-welcome@v1 action.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No description was provided by the author, which is a significant omission for a code change. Add a pull request description explaining the rationale for switching to the Atliac/pr-welcome action and any benefits or considerations.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'use Atliac/pr-welcome' directly and clearly describes the main change: replacing the custom GitHub Script with the Atliac/pr-welcome action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pr-welcome

Comment @coderabbitai help to get the list of available commands and usage tips.

@Atliac
Atliac enabled auto-merge (squash) June 21, 2026 16:54

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a5018926-527b-4dda-8acc-bbf8337863d9

📥 Commits

Reviewing files that changed from the base of the PR and between 6cb7d2f and 1f243f9.

📒 Files selected for processing (1)
  • .github/workflows/pr-welcome.yml

Comment thread .github/workflows/pr-welcome.yml
Comment thread .github/workflows/pr-welcome.yml
@Atliac
Atliac merged commit b8c4c87 into main Jun 21, 2026
14 checks passed
@Atliac
Atliac deleted the pr-welcome branch June 21, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant