Linux+SITL: Fix risk of wrong prng return - #34257
Open
rsaxvc wants to merge 2 commits into
Open
Conversation
Treat an early return of read(/dev/urandom) as a failure.
Treat an early return of read(/dev/urandom) as a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return false from get_random_vals() if it fails to fully populate the destination buffer.
Classification & Testing (check all that apply and add your own)
Testing steps:
Description
Fix a footgun in get_random_vals() when read() returns early due to a signal handler(as may happen during ArduPilot shutdown on SITL or Linux). Some systems will read blocks of 4096B at a time, though the manual states early returns may occur as small as 256B. I couldn't find any mainline ArduPilot code that read()s a large enough buffer to trigger this.